[swift-evolution] [Review] SE-0101: Rename sizeof and related functions to comply with API Guidelines

[Jacob Bandes-Storch]

I'm not sure this bikeshed is the right color yet.

How does the user remember the distinction between MemoryLayout<Int> and
MemoryLayout.of(Int) ? To keep it clear, how about ofValue() rather than
of() ?

Also, could the implementation be simply

    static func ofValue(_ value: @autoclosure () -> T) ->
MemoryLayout<T>.Type {
        return self
    }

?

Jacob

On Wed, Jun 29, 2016 at 7:36 PM, Erica Sadun via swift-evolution <
swift-evolution at swift.org> wrote:

>
> On Jun 29, 2016, at 3:59 PM, Xiaodi Wu via swift-evolution <
> swift-evolution at swift.org> wrote:
>
> On Wed, Jun 29, 2016 at 4:50 PM, David Sweeris <davesweeris at mac.com>
> wrote:
>
>> That’s the “as proposed” usage for getting the size of a value (from
>> https://gist.github.com/erica/57a64163870486468180b8bab8a6294e)
>>
>> // Types
>> MemoryLayout<Int>.size // 8
>> MemoryLayout<Int>.arraySpacing // 8
>> MemoryLayout<Int>.alignment // 8
>> // Valuelet x: UInt8 = 5
>> MemoryLayout(x).dynamicType.size // 1
>> MemoryLayout("hello").dynamicType.arraySpacing // 24
>> MemoryLayout(29.2).dynamicType.alignment // 8
>>
>>
>>
>> At least, I *thought* that was the latest version of the proposal. Maybe
>> I’ve gotten confused.
>>
>
> There must be a typo in these examples. `MemoryLayout(x.dynamicType).size`
> perhaps?
>
>
> I have listened. I have updated.
>
> https://gist.github.com/erica/57a64163870486468180b8bab8a6294e
>
> // Types
> MemoryLayout<Int>.size // 8
> MemoryLayout<Int>.arraySpacing // 8
> MemoryLayout<Int>.alignment // 8
>
> // Value
> let x: UInt8 = 5
> MemoryLayout.of(x).size // 1
> MemoryLayout.of(1).size // 8
> MemoryLayout.of("hello").arraySpacing // 24
> MemoryLayout.of(29.2).alignment // 8
>
>
> -- E
>
>
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160629/297a6661/attachment.html>