[swift-evolution] [Review] SE-0094: Add sequence(initial:next:) and sequence(state:next:) to the stdlib

[David Rönnqvist]

	* What is your evaluation of the proposal?
+1. These are useful additions to the standard library.

Naming the first argument `initial` (in the `T->T?` variant) is consistent with `reduce` and makes it clear (to me) that the initial value is part of the result. 

	* Is the problem being addressed significant enough to warrant a change to Swift?
Yes, these are good building blocks for other functionality and are useful additions to the standard library 

	* Does this proposal fit well with the feel and direction of Swift?
Yes, in both naming and functionality it fits well with existing functions for operating on sequences and collections. Using inout for the state argument nicely leverages the fact that Swift can be functional without some of the restrictions of a _purely_ functional language.

	* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
I’ve used iterate and unfold in Haskell. These additions are true to the usefulness of those two functions, in a Swift style (see above).

	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
Participated in the discussion and review of SE-0045 and the discussion that followed it being accepted with modifications.

- David


> On 20 May 2016, at 00:29, Chris Lattner via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of "SE-0094: Add sequence(initial:next:) and sequence(state:next:) to the stdlib" begins now and runs through May 23. This is a refinement of part of SE-0045.  The proposal is available here:
> 
> 	https://github.com/apple/swift-evolution/blob/master/proposals/0094-sequence-function.md
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> 	https://lists.swift.org/mailman/listinfo/swift-evolution
> 
> or, if you would like to keep your feedback private, directly to the review manager.
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> 	* What is your evaluation of the proposal?
> 	* Is the problem being addressed significant enough to warrant a change to Swift?
> 	* Does this proposal fit well with the feel and direction of Swift?
> 	* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> 
> More information about the Swift evolution process is available at
> 
> 	https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> 
> -Chris Lattner
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution