[swift-evolution] [Review] SE-0089: Renaming String.init<T>(_: T)

Austin Zheng austinzheng at gmail.com
Wed May 18 00:17:54 CDT 2016


I like Jacob's suggestion of "init(describing:)", and I also think the review team should consider the global function alternative. My main goal is also preventing silently incorrect code.

Austin

> On May 17, 2016, at 10:14 PM, Karl Wagner via swift-evolution <swift-evolution at swift.org> wrote:
> 
> I would still prefer a global function; because the output is from reflection, it’s really more for debugging purposes than actually serialising something.
> 
> But any change to this gets a +1 from me. It’s too easy to accidentally call this instead of one of the other argument-less initialisers on String.
> 
> Karl
> 
>> On 18 May 2016, at 05:32, Chris Lattner via swift-evolution <swift-evolution at swift.org> wrote:
>> 
>> Hello Swift community,
>> 
>> The review of "SE-0089: Renaming String.init<T>(_: T)" begins now and runs through May 23. The proposal is available here:
>> 
>> 	https://github.com/apple/swift-evolution/blob/master/proposals/0089-rename-string-reflection-init.md
>> 
>> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
>> 
>> 	https://lists.swift.org/mailman/listinfo/swift-evolution
>> 
>> or, if you would like to keep your feedback private, directly to the review manager.
>> 
>> What goes into a review?
>> 
>> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>> 
>> 	* What is your evaluation of the proposal?
>> 	* Is the problem being addressed significant enough to warrant a change to Swift?
>> 	* Does this proposal fit well with the feel and direction of Swift?
>> 	* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>> 
>> More information about the Swift evolution process is available at
>> 
>> 	https://github.com/apple/swift-evolution/blob/master/process.md
>> 
>> Thank you,
>> 
>> -Chris Lattner
>> Review Manager
>> 
>> 
>> _______________________________________________
>> swift-evolution mailing list
>> swift-evolution at swift.org
>> https://lists.swift.org/mailman/listinfo/swift-evolution
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution



More information about the swift-evolution mailing list