[swift-evolution] [Review] SE-0065 A New Model for Collections and Indices

[Karl]

> Hello Swift community,
> 
> The review of "A New Model for Collections and Indices" begins now and runs through April 18th. The proposal is available here:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0065-collections-move-indices.md<https://github.com/apple/swift-evolution/blob/master/proposals/0055-optional-unsafe-pointers.md>
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:
> https://lists.swift.org/mailman/listinfo/swift-evolution<https://lists.swift.org/mailman/listinfo/swift-evolution>
> or, if you would like to keep your feedback private, directly to the review manager.
> 
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> * What is your evaluation of the proposal?
> * Is the problem being addressed significant enough to warrant a change to Swift?
> * Does this proposal fit well with the feel and direction of Swift?
> * If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> 
> More information about the Swift evolution process is available at
> 
> https://github.com/apple/swift-evolution/blob/master/process.md<https://github.com/apple/swift-evolution/blob/master/process.md>
> 
> Thank you,
> 
> -Chris Lattner
> Review Manager
> 
> 
> 
> 
> 

So, just confirming that the following is going to change:

—————
var string    = "test"
let origLen   = 4
let indexOne  = string.startIndex

string.appendContentsOf("ANOTHERTEST")

let indexTwo = indexOne.advancedBy(origLen, limit: string.endIndex)

assert(indexTwo<string.endIndex)
indexTwo.successor()                           //<--- fatal error: cannot increment endIndex
—————

Is this a consequence of the index needing to know its originating string for successor() purposes?
Once this is implemented, will String.Index be portable across string instances (presuming you bounds-check them, as I did above)?

Thanks

Karl