[swift-evolution] [Review] SE-0052: Change IteratorType post-nil guarantee

Michael Peternell michael.peternell at gmx.at
Mon May 2 14:06:00 CDT 2016

comments below.

> Am 28.04.2016 um 20:12 schrieb Chris Lattner via swift-evolution <swift-evolution at swift.org>:
> Hello Swift community,
> The review of "SE-0052: Change IteratorType post-nil guarantee" begins now and runs through May 3. The proposal is available here:
> 	https://github.com/apple/swift-evolution/blob/master/proposals/0052-iterator-post-nil-guarantee.md
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 	https://lists.swift.org/mailman/listinfo/swift-evolution
> or, if you would like to keep your feedback private, directly to the review manager.
> What goes into a review?
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 	* What is your evaluation of the proposal?

I think it's good

> 	* Is the problem being addressed significant enough to warrant a change to Swift?

Yes, it will demand safe and well-defined behavior from Iterators.

> 	* Does this proposal fit well with the feel and direction of Swift?

Swift is already a very safe language, and producing undefined behavior if someone calls the iterator too often is not nice. Since most iterators already behave nicely (or maybe all?) this shouldn't be a big issue.

> 	* If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

not sure

> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

I read the proposal.


More information about the swift-evolution mailing list