[swift-evolution] [Review] SE-0067: Enhanced Floating Point Protocols
dabrahams at apple.com
Wed Apr 20 14:42:36 CDT 2016
on Tue Apr 19 2016, Xiaodi Wu <swift-evolution at swift.org> wrote:
> * What is your evaluation of the proposal?
> +1 in intent. Specifics require further refinement. For example:
> Internal inconsistencies in capitalization:
> * `signalingNaN` but `isSignalingNan` and `isNan`
> Parameter labels, or whatever they're called now, do not reflect newly
> adopted Swift syntax in SE-0046:
> * `static func maximum(x: Self, _ y: Self) -> Self` should be `static
> func maximum(_ x: Self, _ y: Self) -> Self`, etc.
> Infelicitous use of prepositions to conform superficially to new
> naming guidelines:
> * `isEqual(to:)` is fine, but for consistency there's
> `isLessThanOrEqual(to:)`, which is not fine, because the preposition
> "to" applies only to "equal" and not to "less than"
That seems like a huge stretch to me. Are you claiming it's wrong to
say “x is less than or equal to y,” or are you saying something else?
More information about the swift-evolution