[swift-evolution] [Review] SE-0056: Allow trailing closures in `guard` conditions

[Radosław Pietruszewski]

> What is your evaluation of the proposal?
+1. I like the rule of “don’t make me think”. If I write a piece of code that seems correct to me, why would the compiler “intentionally” stop me from accepting it? Just smooth out this rough edge and remove one scenario in which a compiler error stops me in my work for an error that’s not essential complexity.

Yes, the price of it is a slight inconsistency, as this won’t work with `if foo { … } {`. But I seriously doubt anyone would actually *see* this as inconsistent. Most programmers would just not be stopped for writing `guard foo { … } else`, and would never notice. No error, no problem :) It’s just that now there’s one less place that is a potential error generator ;)

So, yeah, it seems like a fairly straightforward improvement. Not perfect as it doesn’t solve anything, but more like “Why not?"

> Is the problem being addressed significant enough to warrant a change to Swift?
> Does this proposal fit well with the feel and direction of Swift?
Sure, why not ;)

> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
A quick reading, and I’ve roughly followed the initial discussion on the pitch as well.

Best,
— Radek

> On 01 Apr 2016, at 05:27, Douglas Gregor via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of SE-0056 "Allow trailing closures in `guard` conditions" begins now and runs through April 5, 2016. The proposal is available here:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0056-trailing-closures-in-guard.md <https://github.com/apple/swift-evolution/blob/master/proposals/0056-trailing-closures-in-guard.md>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> 
> Proposal link:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0056-trailing-closures-in-guard.md <https://github.com/apple/swift-evolution/blob/master/proposals/0056-trailing-closures-in-guard.md>
> Reply text
> 
> Other replies
>  <https://github.com/apple/swift-evolution#what-goes-into-a-review-1>What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> What is your evaluation of the proposal?
> Is the problem being addressed significant enough to warrant a change to Swift?
> Does this proposal fit well with the feel and direction of Swift?
> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> More information about the Swift evolution process is available at
> 
> https://github.com/apple/swift-evolution/blob/master/process.md <https://github.com/apple/swift-evolution/blob/master/process.md>
> Thank you,
> 
> Doug Gregor
> 
> Review Manager
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160405/312a3788/attachment.html>