[swift-evolution] [Review] SE-0059: Update API Naming Guidelines and Rewrite Set APIs Accordingly

[James Hillhouse]

Hi Doug,

> What is your evaluation of the proposal?
+1

> Is the problem being addressed significant enough to warrant a change to Swift?
Yes. Swift needs strong Set API’s that play nicey-nicey with the API Guidelines and this proposal is a firm effort in that direction.

> Does this proposal fit well with the feel and direction of Swift?
Yes. This proposal takes nouns that have no commonly used verb form and forms them into verbs, e.g. ‘union’ into ‘formUnion’. It may not look especially pretty to some, but is effective.

> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
While not languages, the proposal provides SetAlgebra API that is at least as understandable as Mathematica and much more so than Matlab. 

> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
I’ve been following this discussion since it’s inception back in…what, early February? I have read the API’s and diff’s. Many times.

> On Apr 1, 2016, at 12:14 AM, Douglas Gregor via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of SE-0059 "Update API Naming Guidelines and Rewrite Set APIs Accordingly" begins now and runs through April 5, 2016. The proposal is available here:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0059-updated-set-apis.md <https://github.com/apple/swift-evolution/blob/master/proposals/0059-updated-set-apis.md>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> 
> Proposal link:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0059-updated-set-apis.md <https://github.com/apple/swift-evolution/blob/master/proposals/0059-updated-set-apis.md>
> Reply text
> 
> Other replies
>  <https://github.com/apple/swift-evolution#what-goes-into-a-review-1>What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> What is your evaluation of the proposal?
> Is the problem being addressed significant enough to warrant a change to Swift?
> Does this proposal fit well with the feel and direction of Swift?
> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> More information about the Swift evolution process is available at
> 
> https://github.com/apple/swift-evolution/blob/master/process.md <https://github.com/apple/swift-evolution/blob/master/process.md>
> Thank you,
> 
> Doug Gregor
> 
> Review Manager
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160404/76985388/attachment.html>