[swift-evolution] [Review] SE-0025 Scoped Access Level

[Adrian Kashivskyy]

> What is your evaluation of the proposal?

Neutral. While I agree that scoped access levels can be useful in some cases, I don't see much long-term profits, especially when using a "protocol conformance in an extension" style:

struct Foo {
	private func doSomethingInternal()
}

extension Foo: Barable {
	func bar() {
		doSomethingInternal()
	}
}

The above would not be possible to achieve with scoped access levels.

> Is the problem being addressed significant enough to warrant a change to Swift?

I don't think so. File access level does the job well for me.

> Does this proposal fit well with the feel and direction of Swift?

Yes and no. Yes, because it a

> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Yes, Ruby, PHP, C++. In those languages, there are no file access levels and so the scoped access levels are the only ones which allow to hide the implementation details from the outside world. In Swift, however, file access level allows us to do the same with additional bonus – we can use those `private` members in extensions.

> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?



Pozdrawiam – Regards,
Adrian Kashivskyy

> Wiadomość napisana przez Douglas Gregor via swift-evolution <swift-evolution at swift.org> w dniu 26.02.2016, o godz. 20:05:
> 
> Hello Swift community,
> 
> The review of SE-0025 “Scoped Access Level" begins now and runs through March 3, 2016. The proposal is available here:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0025-scoped-access-level.md <https://github.com/apple/swift-evolution/blob/master/proposals/0025-scoped-access-level.md>
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> 
> Proposal link:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0025-scoped-access-level.md <https://github.com/apple/swift-evolution/blob/master/proposals/0025-scoped-access-level.md>
> Reply text
> 
> Other replies
>  <https://github.com/apple/swift-evolution#what-goes-into-a-review-1>What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> What is your evaluation of the proposal?
> Is the problem being addressed significant enough to warrant a change to Swift?
> Does this proposal fit well with the feel and direction of Swift?
> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> More information about the Swift evolution process is available at
> 
> https://github.com/apple/swift-evolution/blob/master/process.md <https://github.com/apple/swift-evolution/blob/master/process.md>
> Thank you,
> 
> -Doug Gregor
> 
> Review Manager
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160304/8521bfcb/attachment.html>