[swift-evolution] [Review[ SE-0034 Disambiguating Line Control Statements from Debugging Identifiers

[Patrick Gili]

> On Feb 17, 2016, at 11:39 PM, Chris Lattner via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of "Disambiguating Line Control Statements from Debugging Identifiers" begins now and runs through February 22. The proposal is available here:
> 
> 	https://github.com/apple/swift-evolution/blob/master/proposals/0034-disambiguating-line.md
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:
> 	https://lists.swift.org/mailman/listinfo/swift-evolution
> or, if you would like to keep your feedback private, directly to the review manager.
> 
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> 	* What is your evaluation of the proposal?

Seems like SE-0028 created an undesirable side-effect that needs remediation, and hence I approve. Does the community needs to do a better job fleshing out these details moving forward, or was this intentional?

> 	* Is the problem being addressed significant enough to warrant a change to Swift?

Yes.

> 	* Does this proposal fit well with the feel and direction of Swift?

Yes.

> 	* If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Don't know.

> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick read.

> 
> More information about the Swift evolution process is available at
> 
> 	https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> 
> -Chris Lattner
> Swift Intern
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution