[swift-evolution] [swift-evolution-announce] [Review] SE-0028 Modernizing Swift's Debugging Identifiers (__LINE__, etc)

[Matthew Johnson]

	* What is your evaluation of the proposal?

+1.  I really like the idea of using octothorpe for compiler-supported expressions.

I would like to see either #file and / or #symbol included.

I also like Kevin’s idea of renaming the existing #line to #setline.  That reduces potential confusion while giving the existing feature a better name.

Even better would be the #sourcelocation

	* Is the problem being addressed significant enough to warrant a change to Swift?

Yes, it improves overall consistency of the language and removes the shouty legacy from C.

	* Does this proposal fit well with the feel and direction of Swift?

Yes.

	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

I followed the original thread, read the proposal, and also previous reviews.

> On Jan 29, 2016, at 1:31 PM, Chris Lattner <clattner at apple.com> wrote:
> 
> Hello Swift community,
> 
> The review of "Modernizing Swift's Debugging Identifiers" begins now and runs through February 2nd. The proposal is available here:
> 
> 	https://github.com/apple/swift-evolution/blob/master/proposals/0028-modernizing-debug-identifiers.md
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> 	https://lists.swift.org/mailman/listinfo/swift-evolution
> 
> or, if you would like to keep your feedback private, directly to the review manager.
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> 	* What is your evaluation of the proposal?
> 	* Is the problem being addressed significant enough to warrant a change to Swift?
> 	* Does this proposal fit well with the feel and direction of Swift?
> 	* If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> 
> More information about the Swift evolution process is available at
> 
> 	https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> 
> -Chris Lattner
> Review Manager
> _______________________________________________
> swift-evolution-announce mailing list
> swift-evolution-announce at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution-announce