[swift-evolution] [Review] SE-0028 Modernizing Swift's Debugging Identifiers (__LINE__, etc)

Adrian Kashivskyy adrian.kashivskyy at me.com
Fri Jan 29 13:49:50 CST 2016


> What is your evaluation of the proposal?

I'm +1 on this. In my opinion it aligns well with other static compiler directives such as `#selector`, `#available`, #if`.

> Is the problem being addressed significant enough to warrant a change to Swift?

Yes, those identifiers are used often when debugging (especially logging).

> Does this proposal fit well with the feel and direction of Swift?

Definetely yes. It removes yet another C artifact which cannot be justified in any way except of familiarity. Also, `#`-prefixed keywords fit well with other compiler expressions (this argument was mentioned in the proposal itself).

> If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Obviously, in C family languages. As C family libraries and frameworks tend to name their basic constants using `__SCREAMING_SNAKE_CASE__` format so that `__FILE__` fits well among them, it is not the case in Swift.

Pozdrawiam – Regards,
Adrian Kashivskyy

> Wiadomość napisana przez Chris Lattner via swift-evolution <swift-evolution at swift.org> w dniu 29.01.2016, o godz. 20:31:
> 
> Hello Swift community,
> 
> The review of "Modernizing Swift's Debugging Identifiers" begins now and runs through February 2nd. The proposal is available here:
> 
> 	https://github.com/apple/swift-evolution/blob/master/proposals/0028-modernizing-debug-identifiers.md
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at
> 
> 	https://lists.swift.org/mailman/listinfo/swift-evolution
> 
> or, if you would like to keep your feedback private, directly to the review manager.
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> 	* What is your evaluation of the proposal?
> 	* Is the problem being addressed significant enough to warrant a change to Swift?
> 	* Does this proposal fit well with the feel and direction of Swift?
> 	* If you have you used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> 
> More information about the Swift evolution process is available at
> 
> 	https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> 
> -Chris Lattner
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160129/04f6ae44/attachment.html>


More information about the swift-evolution mailing list