[swift-evolution] [Review] SE-0006 Apply API Guidelines to the Standard Library

[Ondrej Barina]

+1 for proposal
Ondrej

On Sat, Jan 23, 2016 at 9:59 AM, Jacob Bandes-Storch via swift-evolution <
swift-evolution at swift.org> wrote:

> Proposal link:
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0006-apply-api-guidelines-to-the-standard-library.md
>
> > What is your evaluation of the proposal?
>
> I believe the Unmanaged -> UnsafeReference / OpaquePointer changes are too
> large to be part of this proposal; they should be reviewed separately.
> There was some discussion about this in a thread last month. Particularly,
> I'm concerned that there is still a gap between UnsafePointer<Void> and
> OpaquePointer APIs. I submitted a related proposal, SE-0017, which was
> never scheduled for review:
>
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0017-convert-unmanaged-to-use-unsafepointer.md
>
> I'm also a little concerned about Integer, SignedInteger, and
> UnsignedInteger, which are protocols but might look like concrete integer
> types to the reader. My first thought is that "Integral" would be better
> for this, but it doesn't match the "noun or capability" note in the API
> design guidelines.
>
> Otherwise, I'm generally fine with the proposed changes.
>
>
> > Is the problem being addressed significant enough to warrant a change to
> Swift?
>
> Yes; consistency is important.
>
>
> > Does this proposal fit well with the feel and direction of Swift?
>
> Yes, by definition.
>
>
> > How much effort did you put into your review? A glance, a quick reading,
> or an in-depth study?
>
> Fairly in-depth.
>
> Jacob
>
> On Fri, Jan 22, 2016 at 1:02 PM, Douglas Gregor via swift-evolution <
> swift-evolution at swift.org> wrote:
>
>> Hello Swift community,
>>
>> The review of SE-0006 "Apply API Guidelines to the Standard Library"
>> begins now and runs through January 31, 2016. The proposal is available
>> here:
>>
>>
>> https://github.com/apple/swift-evolution/blob/master/proposals/0006-apply-api-guidelines-to-the-standard-library.md
>>
>> Reviews are an important part of the Swift evolution process. All reviews
>> should be sent to the swift-evolution mailing list at
>>
>> https://lists.swift.org/mailman/listinfo/swift-evolution
>>
>> or, if you would like to keep your feedback private, directly to the
>> review manager. When replying, please try to keep the proposal link at the
>> top of the message:
>>
>> Proposal link:
>>
>>
>> https://github.com/apple/swift-evolution/blob/master/proposals/0006-apply-api-guidelines-to-the-standard-library.md
>>
>> Reply text
>>
>> Other replies
>>
>> <https://github.com/apple/swift-evolution#what-goes-into-a-review-1>What
>> goes into a review?
>>
>> The goal of the review process is to improve the proposal under review
>> through constructive criticism and, eventually, determine the direction of
>> Swift. When writing your review, here are some questions you might want to
>> answer in your review:
>>
>>    - What is your evaluation of the proposal?
>>    - Is the problem being addressed significant enough to warrant a
>>    change to Swift?
>>    - Does this proposal fit well with the feel and direction of Swift?
>>    - If you have used other languages or libraries with a similar
>>    feature, how do you feel that this proposal compares to those?
>>    - How much effort did you put into your review? A glance, a quick
>>    reading, or an in-depth study?
>>
>> More information about the Swift evolution process is available at
>>
>> https://github.com/apple/swift-evolution/blob/master/process.md
>>
>> Thank you,
>>
>> -Doug Gregor
>>
>> Review Manager
>>
>> _______________________________________________
>> swift-evolution mailing list
>> swift-evolution at swift.org
>> https://lists.swift.org/mailman/listinfo/swift-evolution
>>
>>
>
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160123/5cec3cb7/attachment.html>