[swift-evolution] Custom summary for Mirrors?
dabrahams at apple.com
Tue Jan 19 18:24:43 CST 2016
on Tue Jan 19 2016, Austin Zheng <austinzheng-AT-gmail.com> wrote:
> Hi Dave,
> On Tue, Jan 19, 2016 at 10:46 AM, Dave Abrahams <dabrahams at apple.com> wrote:
>> > Agreed, I think we can easily do it internally for the use cases that
>> > are most important (collections, certain built-in types), etc. It's
>> > probably out-of-scope for the PR I have out right now
>> > (https://bugs.swift.org/browse/SR-88
>> > <https://bugs.swift.org/browse/SR-88>), but maybe I can sketch an
>> > implementation and we can discuss further on swift-dev. (Since it's
>> > all internal changes and no public-facing API changes the entire
>> > swift-evolution process probably isn't necessary.) LMK if you think
>> > that's the best way to proceed.
>> It sounds like a fine plan. You'd have to land it before SR-88 to
>> keep the tests working, right?
> The PR for SR-88 actually has changes to all the tests to keep them passing
> without doing any additional work. If I did do the work described above (to
> prettify the common use cases), I'd just remove those test changes and keep
> the tests the way they look right now.
> This means I can either:
> 1. Land the PR now, and then make the prettifying changes + revert the
> tests and commit that as another PR
> 2. Add the prettifying changes as part of the current PR and delete the
> changes I made to the tests (this will make the PR a lot smaller overall;
> many of the changes to the test files will disappear)
> Let me know if that makes sense.
I like #2 for minimizing VCS churn.
More information about the swift-evolution