[swift-evolution] Proposal: Implement a rotate algorithm, equivalent to std::rotate() in C++

Dmitri Gribenko gribozavr at gmail.com
Tue Dec 29 00:38:53 CST 2015

On Mon, Dec 28, 2015 at 10:29 PM, Sergey Bolshedvorsky via swift-evolution <
swift-evolution at swift.org> wrote:

> Hi all,
> I have created a PR with with a formal proposal for this feature:
> https://github.com/apple/swift-evolution/pull/77
> What are your thoughts?

Thank you for the proposal!

What jumps at me immediately is that the APIs are using integers to specify
positions in the collection.  I think they should be using collection's
indices instead.

I'm unsure why we need `first` and `last` -- shouldn't the API operate on
the whole collection?  We have slices to operate on subsequences.

It is interesting that you are proposing that the new algorithms should
produce lazy views.  I agree this is consistent with the rest of the
library, but I'm worried about the performance implications.  Have you
thought about this?  One point to keep in mind is that you can implement
the `_copyToNativeArrayBuffer()` and `_initializeTo()` entry points in all
new lazy collections, using the optimal eager algorithm.  This way,
converting them to arrays will be fast.

Another point to consider is how the call site of these functions looks

collection.rotate(10, middle: 20, last: 30)

The first number hangs in the air, it is unclear what its meaning is.


(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20151229/5c7ad8fb/attachment.html>

More information about the swift-evolution mailing list