[swift-evolution] Proposal: Allow `[strong self]` capture in closures and remove the `self` requirement therein

[Drew Crawford]

Big -1

Consider the following

//somewherelse.swift

var strongReference: Foo! = nil
func evil(foo: Foo) {
    strongReference = foo
}

and

//Foo.swift
class Bar {
    var f: Foo
    dispatch_async(queue) { [strong self] in
         evil(f)
    }
}

IMHO, `evil(self.f)` is *far* better and *far* more likely to look like a bug.  I feel so strongly about this that I would take the extraordinary step of banning `strong self` from my codebase.  I have spent waaaaaaay too much time playing "spot func evil".

Obviously reasonable people can disagree about "more likely" but "this sort of retain cycle creep" is how we ended up with the problems in this post <http://sealedabstract.com/code/nsnotificationcenter-with-blocks-considered-harmful/>, and one of the secret advantages of Swift is those bugs are SO MUCH HARDER.

Additional compiler diagnostics may help here, (which I want to see regardless) but unless those come in as part of the same proposal I'm -1.


> On Dec 15, 2015, at 5:02 PM, Greg Parker via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Swift currently requires that `self` be used explicitly inside closures, to help avoid bugs from unintentional capture. This is annoying when a closure uses `self` a lot. Closures should be allowed to name `[strong self]` in their capture list and thereafter not be required to write `self` everywhere.
> 
> I wrote code this weekend that looked something like this:
> 
>    data = ...
>    running = true
>    delegate.notifyBegin(data)
> 
>    dispatch_async(queue) {
>        self.processData(self.data)
>        self.running = false
>        self.delegate.notifyEnd(self.data)
>    }
> 
> Note the asymmetry: the dispatched code needs to use `self` and the non-dispatched code does not. It is clear that the dispatched closure captures `self`, but it's annoying that it needed to be mentioned five different times. The noise gets worse with longer closures. The annoyance gets worse when moving code in and out of dispatches or other closures, with lots of editing required each time.
> 
> The proposal would allow the same code to be written like this:
> 
>    data = ...
>    running = true
>    delegate.notifyBegin(data)
> 
>    dispatch_async(queue) {
>        [strong self] in
>        processData(data)
>        running = false
>        delegate.notifyEnd(data)
>    }
> 
> Advantages:
> * The dispatch'ed code looks like the non-dispatched code. 
> * The capture of `self` is still obvious.
> * The code's action is clearer without the `self` noise.
> 
> Disadvantages:
> * The capture behavior of self's properties is less obvious. For example, neither closure above captured its own copy of `self.data`, but that behavior is not immediately visible in the second closure.
> 
> 
> What about [weak self] and [unowned self] ? I do not propose to change the `self` requirement for those closures. In the weak case it is critically important to know where `self` is accessed, because it could potentially become nil between any two accesses. Unowned self might be reasonable to change, but for simplicity I won't do so here.
> 
> 
> -- 
> Greg Parker     gparker at apple.com     Runtime Wrangler
> 
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20151215/cb58046b/attachment.html>