<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 4, 2018, at 11:14 AM, Vedant Kumar <<a href="mailto:vsk@apple.com" class="">vsk@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">To follow up on this thread, I reverted #13597 (the profiling refactor) because I couldn't get a clean run of the source compat suite.<div class=""><br class=""></div><div class="">It looks like there's an issue unrelated to #13597 causing a few failures: <a href="https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/1017/" class="">https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/1017/</a></div><div class=""><div class=""><div class=""><pre class="">ld: warning: unable to create link snapshot directory: /tmp/AsyncNinja-2018-00-04-030527.ld-snapshot
ld: snapshot not created in 'l_protocol_conformances' from /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/AsyncNinja/build/Build/Intermediates.noindex/AsyncNinja.build/Release-iphoneos/AsyncNinja.build/Objects-normal/arm64/iOS.o for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)</pre></div></div></div></div></div></blockquote><div><br class=""></div>This is probably mine. Trying to reproduce now.</div><div><br class=""></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class=""><div class=""><div class="">vedant</div></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jan 3, 2018, at 7:34 PM, Mark Lacey <<a href="mailto:mark.lacey@apple.com" class="">mark.lacey@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline"><br class=""><blockquote type="cite" class=""><div class="">On Jan 3, 2018, at 7:31 PM, Vedant Kumar <<a href="mailto:vsk@apple.com" class="">vsk@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" class=""><div class=""><br class="Apple-interchange-newline">On Jan 3, 2018, at 7:23 PM, Mark Lacey <<a href="mailto:mark.lacey@apple.com" class="">mark.lacey@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;"><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Jan 3, 2018, at 7:18 PM, Vedant Kumar <<a href="mailto:vsk@apple.com" class="">vsk@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;"><span class="">This is a bit surprising, since I wouldn't expect this suite of tests to stress the code coverage logic.</span><div class=""><span class=""><br class=""></span></div><div class=""><span class="">How were you able to determine that the #13597 caused the break?<span class="Apple-converted-space"> </span></span></div></div></div></blockquote><div class=""><br class=""></div><div class="">I’m seeing this in the failing builds:</div><div class=""><br class=""></div><div class=""><div class="">Assertion failed: (std::all_of(Mappings.begin(), Mappings.end(), [](const SILCoverageMap &M) { return M.hasSymtabEntry(); }) && "Missing symtab entry for coverage mapping"), function emitCoverageMapping, file /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/swift/lib/IRGen/GenCoverage.cpp, line 53.</div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">I added this assert as a debugging tool, with plans on making it a defensive measure. I.e, we'd use the check to avoid emitting broken coverage mapping data. Instead of reverting, it might be easier to finish that up. Wdyt?</div></div></div></blockquote><div class=""><br class=""></div>Is that something you can do quickly?</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">It’s blocking PR testing for source compatibility, which means we get no coverage for people that want to run those tests until this is fixed or reverted.</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Mark</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" class=""><div class=""><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;"><div class=""><div class=""><div class=""><br class=""></div></div><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;"><div class=""><span class="">I'm having a hard time understanding what the logs mean. For example, I see this failure, but I'm not sure how my change relates to it:</span></div></div></div></blockquote><div class=""><br class=""></div><div class="">It’s non-obvious, but the easiest thing to do is download the build artifacts via a couple clicks from <a href="https://ci.swift.org/job/swift-master-source-compat-suite/1014/" class="">https://ci.swift.org/job/swift-master-source-compat-suite/1014/</a>, and then look at the logs named FAIL_*.</div></div></div></div></blockquote><div class=""><br class=""></div>Thanks, I see the failures now.</div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""></div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;"><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;"><div class=""><span class=""><br class=""></span></div><div class=""><pre class="" style="word-wrap: break-word; white-space: pre-wrap;">FAIL: JSQDataSourcesKit, 3.0, b764e3, JSQDataSourcesKit-iOS, generic/platform=iOS, ExecuteCommandFailure(command="sandbox-exec -f /Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_xcodebuild.sb xcodebuild clean build -project /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/JSQDataSourcesKit.xcodeproj -target JSQDataSourcesKit-iOS -destination generic/platform=iOS SYMROOT=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/build -sdk /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ENABLE_BITCODE=NO INDEX_ENABLE_DATA_STORE=NO GCC_TREAT_WARNINGS_AS_ERRORS=NO SWIFT_TREAT_WARNINGS_AS_ERRORS=NO 'OTHER_SWIFT_FLAGS=$(OTHER_SWIFT_FLAGS) -swift-version 3' -configuration Release SWIFT_EXEC=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swiftc SWIFT_VERSION=3", returncode=65)</pre><div class="">Can I reproduce the issue with `build-script -t`?</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">You should be able to reproduce by building and then following the instructions here to run a single project build: <a href="https://github.com/apple/swift-source-compat-suite/blob/master/README.md" class="">https://github.com/apple/swift-source-compat-suite/blob/master/README.md</a></div></div></div></div></blockquote><div class=""><br class=""></div>Thanks.</div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""></div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">vedant</div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""></div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;"><div class=""><div class=""><br class=""></div><div class="">Mark</div><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;"><div class=""><div class=""><br class=""></div><div class="">thanks,</div><div class="">vedant</div><span class=""><br class=""></span><div class=""><blockquote type="cite" class=""><div class="">On Jan 3, 2018, at 7:10 PM, Mark Lacey <<a href="mailto:mark.lacey@apple.com" class="">mark.lacey@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space;">Vedant, this appears to be a result of your changes.<div class=""><br class=""></div><div class="">I’ve opened <a href="https://github.com/apple/swift/pull/13709" class="">https://github.com/apple/swift/pull/13709</a> to revert the later clean-up change which appears to be required before it will be possible to revert the change below.</div><div class=""><br class=""></div><div class="">Mark<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Jan 3, 2018, at 6:06 PM,<span class="Apple-converted-space"> </span><a href="mailto:swift-ci@swift.org" class="">swift-ci@swift.org</a><span class="Apple-converted-space"> </span>wrote:</div><br class="Apple-interchange-newline"><div class=""><h2 class="" style="font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; width: 665px; background-color: red; color: white; text-align: center;"></h2><h1 class="" style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">[<font class="FAILURE" style="color: red;">FAILURE</font>] swift-master-source-compat-suite [#1014]</h1><table class="" style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><tbody class=""><tr class="" style="text-align: left;"><th class="">Build URL:</th><td class=""><a href="https://ci.swift.org/job/swift-master-source-compat-suite/1014/" class="" style="color: rgb(0, 122, 255); text-decoration: none;">https://ci.swift.org/job/swift-master-source-compat-suite/1014/</a></td></tr><tr class="" style="text-align: left;"><th class="">Project:</th><td class="">swift-master-source-compat-suite</td></tr><tr class="" style="text-align: left;"><th class="">Date of build:</th><td class="">Wed, 03 Jan 2018 16:40:37 -0600</td></tr><tr class="" style="text-align: left;"><th class="">Build duration:</th><td class="">3 hr 26 min</td></tr></tbody></table><br class="" style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><h2 class="" style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Changes</h2><ul class="" style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><li class="">Commit<span class="Apple-converted-space"> </span><b class="">5307f5d2ecdbcab62ae203ef21d2e1b95e2723f7</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Add "reserved" protocol conformance kind and ignore it.</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ProtocolConformance.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: include/swift/ABI/MetadataValues.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">8c668ba524969856496f2b96f6efca188a36c2f6</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Rename the segment for protocol conformance records.</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionCOFF.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionELF.h</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionELF.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionCOFF.h</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionMachO.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/SwiftRT-ELF.cpp</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">314d705f417b357d03c99e9153cf819d13df595e</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">mark.lacey:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Sema: Look through inout when mapping IUOs to Optionals.</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/Decl.cpp</li><li class="change-edit"><b class="">edit</b>: test/decl/overload.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">7e6f52308d4db11ef6e560f63235e5cfa4346c6d</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Move conformance kind into low bits of witness table</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/Basic/RelativePointer.h</li><li class="change-edit"><b class="">edit</b>: docs/ABI/TypeMetadata.rst</li><li class="change-edit"><b class="">edit</b>: test/IRGen/protocol_conformance_records.swift</li><li class="change-edit"><b class="">edit</b>: include/swift/ABI/MetadataValues.h</li><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">32ab89b0cc149a86cde206cca67bfeb27bd42521</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Reference ObjC class objects indirectly in conformance</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/IRGen/protocol_conformance_records_objc.swift</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: test/IRGen/objc_bridged_generic_conformance.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">e3d6a2b9a2b3bbc80a1ccf5079a76751ff6a05ec</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">IRGen: Correctly set class metadata base offset variable</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/IRGen/class_resilience.swift</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenMeta.cpp</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/MetadataLayout.cpp</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/MetadataLayout.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">22f08f7f472dee57ffb1e7d9678411bcd87fc4a8</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Runtime: Set metadata size when allocating runtime-sized class metadata</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/Metadata.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">c1782d8cc01e5b7e5da6643c946c2c618575ec1b</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Eliminate the UniqueDirectClass metadata record kind.</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/MetadataLookup.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/ABI/MetadataValues.h</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ProtocolConformance.cpp</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li><li class="change-edit"><b class="">edit</b>: test/IRGen/protocol_conformance_records.swift</li><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">fea92a0214aaf7f61a676d6dd3b9efdf695ed848</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Runtime: Add support for resilient superclasses</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: include/swift/Remote/MetadataReader.h</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/Metadata.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/Demangle.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">b25dc440691e07c4f9e34ba388fd91e0bf1d2abd</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Cast to the correct type.</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">d64592264ed02e9181c847b3ec6bf3bd5ce61aab</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Use nominal type descriptor references for non-foreign types.</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ProtocolConformance.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/MetadataLookup.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/ABI/MetadataValues.h</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenClass.cpp</li><li class="change-edit"><b class="">edit</b>: test/IRGen/protocol_conformance_records.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">66ba75cef7009c8916cbad63266fe29187756b49</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">IRGen: Update super.sil test to use -enable-class-resilience</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/IRGen/super.sil</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">6af8d18a008915f6b905e59e0adc6ae7b6c71ad6</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">IRGen: Remove -enable-class-resilience staging flag</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/Basic/LangOptions.h</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenClass.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Frontend/CompilerInvocation.cpp</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/ClassMetadataVisitor.h</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/MetadataLayout.cpp</li><li class="change-edit"><b class="">edit</b>: test/IRGen/super.sil</li><li class="change-edit"><b class="">edit</b>: test/IRGen/class_resilience.swift</li><li class="change-edit"><b class="">edit</b>: include/swift/Option/FrontendOptions.td</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">6347112a04eb1532a0f0cee1a9b5ea8b4bcd331d</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">mark.lacey:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Downgrade from error to warning for overloading by kind of optional.</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/decl/overload.swift</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckDecl.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/DiagnosticsSema.def</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">77a29c9551df516707b7b046699f51c8655f9270</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dave:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[AST] Perf: Improve getDesugaredType() efficiency</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/AST/Types.h</li><li class="change-edit"><b class="">edit</b>: include/swift/Basic/InlineBitfield.h</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/TypeNodes.def</li><li class="change-edit"><b class="">edit</b>: lib/AST/Type.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/SIL/SILNode.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">aee0c681e40d89442c2f9f3da496779b0942d2c4</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Pack TypeMetadataRecordKind into spare bits of protocol</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/IRGen/protocol_conformance_records.swift</li><li class="change-edit"><b class="">edit</b>: test/IRGen/protocol_conformance_records_objc.swift</li><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: include/swift/ABI/MetadataValues.h</li><li class="change-edit"><b class="">edit</b>: include/swift/Basic/RelativePointer.h</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ProtocolConformance.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">e5a0c968ab65467b167978d743b5d959c8c708bc</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">mark.lacey:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Fix inout optional overload warning for methods.</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/AST/DiagnosticsSema.def</li><li class="change-edit"><b class="">edit</b>: test/decl/overload.swift</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckDecl.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">bfd2230c6d93d0d004219bbd1f722a59a0791346</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Eliminate ProtocolConformanceFlags.</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/IRGen/protocol_conformance_records_objc.swift</li><li class="change-edit"><b class="">edit</b>: test/IRGen/protocol_conformance_records.swift</li><li class="change-edit"><b class="">edit</b>: docs/ABI/TypeMetadata.rst</li><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">310bd6be4854618154edeb4a929c2d14ce3ed988</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Mangle the reference kind in the lower two bits of type</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionELF.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionELF.h</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/SwiftRT-ELF.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionCOFF.cpp</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/IRGenModule.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionMachO.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ImageInspectionCOFF.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">aba9d537368ecf186f9c191ddbfbcb7b5230e027</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">vsk:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Coverage] Refactor SIL generation for profiling</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenFunction.h</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenDestructor.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenConstructor.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/SIL/SILCoverageMap.h</li><li class="change-edit"><b class="">edit</b>: lib/SIL/SILCoverageMap.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenPattern.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGen.h</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenExpr.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/SIL/SILFunction.h</li><li class="change-edit"><b class="">edit</b>: include/swift/SIL/SILModule.h</li><li class="change-delete"><b class="">delete</b>: lib/SILGen/SILGenProfiling.h</li><li class="change-delete"><b class="">delete</b>: lib/SILGen/SILGenProfiling.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGen.cpp</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenCoverage.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/coverage_ternary.swift</li><li class="change-add"><b class="">add</b>: include/swift/SIL/SILProfiler.h</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/CMakeLists.txt</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenFunction.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenType.cpp</li><li class="change-add"><b class="">add</b>: lib/SIL/SILProfiler.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenStmt.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SIL/CMakeLists.txt</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">3219047783988026ecd45e330711e21c0f4a8cca</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[Runtime] Clean up TypeMetadataRecordKind and</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/Runtime/Metadata.h</li><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenDecl.cpp</li><li class="change-edit"><b class="">edit</b>: stdlib/public/runtime/ProtocolConformance.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/ABI/MetadataValues.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">e44eb34cd665e086c7d6cabb240ea6ccb03f15ed</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">blangmuir:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[code-complete] Don't suggest trailing closure for autoclosure</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/IDE/complete_trailing_closure.swift</li><li class="change-edit"><b class="">edit</b>: lib/IDE/CodeCompletion.cpp</li></ul></li></ul></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></blockquote></div></div></blockquote></div></div></blockquote></div><br class=""></div></div></div></div></div></blockquote></div><br class=""></body></html>