<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Reverted. Thanks Doug.<div><br><div id="AppleMailSignature">Sent from my iPhone</div><div><br>On Dec 13, 2017, at 10:54 PM, Douglas Gregor via swift-dev <<a href="mailto:swift-dev@swift.org">swift-dev@swift.org</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="Content-Type" content="text/html; charset=utf-8">I’m checking that theory with<div class=""><br class=""></div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span><a href="https://github.com/apple/swift/pull/13427" class="">https://github.com/apple/swift/pull/13427</a></div><div class=""><br class=""></div><div class="">and will complete the revert if that PR runs clean.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 13, 2017, at 10:08 PM, Douglas Gregor via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none;" class="">Arnold, these backtraces imply that it’s your change. </span><br style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><div style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Sent from my iPhone</div><div style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class="">On Dec 13, 2017, at 9:54 PM,<span class="Apple-converted-space"> </span><a href="mailto:swift-ci@swift.org" style="color: rgb(0, 122, 255); text-decoration: none;" class="">swift-ci@swift.org</a><span class="Apple-converted-space"> </span>wrote:<br class=""><br class=""></div><blockquote type="cite" style="font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><div class=""><h2 style="width: 703px; background-color: red; color: white; text-align: center;" class=""></h2><h1 class="">[<font class="FAILURE" style="color: red;">FAILURE</font>] swift-master-source-compat-suite [#916]</h1><table class=""><tbody class=""><tr style="text-align: left;" class=""><th class="">Build URL:</th><td class=""><a href="https://ci.swift.org/job/swift-master-source-compat-suite/916/" style="color: rgb(0, 122, 255); text-decoration: none;" class="">https://ci.swift.org/job/swift-master-source-compat-suite/916/</a></td></tr><tr style="text-align: left;" class=""><th class="">Project:</th><td class="">swift-master-source-compat-suite</td></tr><tr style="text-align: left;" class=""><th class="">Date of build:</th><td class="">Wed, 13 Dec 2017 20:35:21 -0600</td></tr><tr style="text-align: left;" class=""><th class="">Build duration:</th><td class="">3 hr 18 min</td></tr></tbody></table><br class=""><h2 class="">Changes</h2><ul class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">beed602bdc4eb7eeaa56fb637e4660451fb26879</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[NFC] Fix new file headers</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/RequirementEnvironment.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/RequirementEnvironment.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">dc5888d8878854436fa359a3a649efbc1c854104</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">blangmuir:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[parse] Recover better from malformed subscript decls for</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckDecl.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/Decl.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Parse/ParseDecl.cpp</li><li class="change-edit"><b class="">edit</b>: test/Parse/subscripting.swift</li><li class="change-add"><b class="">add</b>: test/IDE/complete_type_subscript.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">8610670d0e967a02a30d9dfac41885cf6908bcd2</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">aschwaighofer:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">IRGen: The partial application forwarder needs to cast {</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenFunc.cpp</li><li class="change-add"><b class="">add</b>: test/IRGen/objc_partial_apply_forwarder.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">cabdf841795279c390af9bbb8ae56ba4e7a71c7e</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">dgregor:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Suggest @objc for overrides of declarations from/in extensions.</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/decl/inherit/override.swift</li><li class="change-edit"><b class="">edit</b>: test/Compatibility/attr_override.swift</li><li class="change-edit"><b class="">edit</b>: test/decl/class/classes.swift</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeChecker.h</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/DiagnosticsSema.def</li><li class="change-edit"><b class="">edit</b>: test/decl/func/static_func.swift</li><li class="change-edit"><b class="">edit</b>: test/attr/attr_objc_override.swift</li><li class="change-edit"><b class="">edit</b>: test/decl/var/properties.swift</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckDecl.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckType.cpp</li><li class="change-edit"><b class="">edit</b>: test/attr/attr_override.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">2254c586a4f5f6915be5f673e7edf636d0038e08</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Serialization: Use castTo instead of getAs in a few places to turn null</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Serialization/DeserializeSIL.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">22edb62dc709b4bbc8bfda881e08e046199a8087</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Serialization: Fix crash when deserializing store_unowned SIL</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Serialization/DeserializeSIL.cpp</li><li class="change-edit"><b class="">edit</b>: test/Serialization/Inputs/def_basic.sil</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">9ddd60d4ef753ca12ffb41ed360ca67f96e23eb1</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">github:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">libSyntax: create syntax nodes for closure signature. (#13415)</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/Syntax/round_trip_parse_gen.swift</li><li class="change-edit"><b class="">edit</b>: lib/Parse/ParsePattern.cpp</li><li class="change-edit"><b class="">edit</b>: utils/gyb_syntax_support/ExprNodes.py</li><li class="change-edit"><b class="">edit</b>: lib/Parse/ParseExpr.cpp</li><li class="change-edit"><b class="">edit</b>: unittests/Syntax/DeclSyntaxTests.cpp</li><li class="change-edit"><b class="">edit</b>: utils/gyb_syntax_support/DeclNodes.py</li><li class="change-edit"><b class="">edit</b>: test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">796c51cb1f2532e51fb9266097bd55e69e5a41b4</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">github:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">libSyntax: specialize closure expression. (#13421)</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds</li><li class="change-edit"><b class="">edit</b>: utils/gyb_syntax_support/ExprNodes.py</li><li class="change-edit"><b class="">edit</b>: lib/Parse/ParseExpr.cpp</li><li class="change-edit"><b class="">edit</b>: test/Syntax/round_trip_parse_gen.swift</li></ul></li><br class=""></ul></div></blockquote><span style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none;" class="">_______________________________________________</span><br style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><span style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none;" class="">swift-dev mailing list</span><br style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><a href="mailto:swift-dev@swift.org" style="color: rgb(0, 122, 255); text-decoration: none; font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">swift-dev@swift.org</a><br style="color: rgb(57, 57, 57); font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" style="color: rgb(0, 122, 255); text-decoration: none; font-family: "Helvetica Neue", sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a></div></blockquote></div><br class=""></div></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>swift-dev mailing list</span><br><span><a href="mailto:swift-dev@swift.org">swift-dev@swift.org</a></span><br><span><a href="https://lists.swift.org/mailman/listinfo/swift-dev">https://lists.swift.org/mailman/listinfo/swift-dev</a></span><br></div></blockquote></div></body></html>