<div dir="ltr"><div class="gmail_extra"><div><div class="gmail_signature"><br></div></div><div class="gmail_quote">On Thu, Nov 9, 2017 at 5:41 PM, Pavel Yaskevich <span dir="ltr"><<a href="mailto:pyaskevich@apple.com" target="_blank">pyaskevich@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">Hi Ahmed,<div><br></div><div> There is a problem in CodeGen:</div><div><br></div><div><pre class="gmail-m_1313309927814604951console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;font-size:13px;background-color:rgb(43,48,59);color:rgb(192,197,206);padding:20px;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;font-variant-ligatures:normal"><span title="Compile Error" style="box-sizing:border-box;color:white;background-color:red">/home/buildnode/jenkins/<wbr>workspace/oss-swift-<wbr>incremental-RA-linux-ubuntu-<wbr>14_04/llvm/tools/clang/lib/<wbr>CodeGen/CodeGenAction.cpp:50:<wbr>47: error: expected class name
</span> class ClangDiagnosticHandler final : public DiagnosticHandler {
</pre><div><br></div><div> Can you please take a look?</div></div></div></blockquote><div><br></div><div><br></div><div>Huh, that should be handled by the associated clang commits. I'm only seeing a similar issue in swift (you probably need to cherry-pick something similar, related to opt-remarks):</div><div><br></div><div><pre class="gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;font-size:13px;background-color:rgb(43,48,59);color:rgb(192,197,206);padding:20px;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px"><span title="Compile Error" style="box-sizing:border-box;color:white;background-color:red">/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/swift/lib/Immediate/Immediate.cpp:200:28: error: reference to type 'std::unique_ptr<DiagnosticHandler>' could not bind to an lvalue of type 'void (const llvm::DiagnosticInfo &, void *)'
</span> Ctx.setDiagnosticHandler(linkerDiagnosticHandler, nullptr);
^~~~~~~~~~~~~~~~~~~~~~~
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/llvm/include/llvm/IR/LLVMContext.h:211:66: note: passing argument to parameter 'DH' here
void setDiagnosticHandler(std::unique_ptr<DiagnosticHandler> &&DH,
^
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/swift/lib/Immediate/Immediate.cpp:202:28: error: rvalue reference to type 'unique_ptr<[2 * ...]>' cannot bind to lvalue of type 'unique_ptr<[2 * ...]>'
Ctx.setDiagnosticHandler(OldHandler, OldDiagnosticContext);
^~~~~~~~~~
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/llvm/include/llvm/IR/LLVMContext.h:211:66: note: passing argument to parameter 'DH' here
void setDiagnosticHandler(std::unique_ptr<DiagnosticHandler> &&DH,
^
2 errors generated.</pre></div><div><br></div><div>at:</div><div><a href="https://ci.swift.org//job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/consoleFull#-20360024703122a513-f36a-4c87-8ed7-cbc36a1ec144">https://ci.swift.org//job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/consoleFull#-20360024703122a513-f36a-4c87-8ed7-cbc36a1ec144</a><br></div><div><br></div><div>Where's the clang error?</div><div><br></div><div>-Ahmed</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><div>Best Regards, Pavel.</div><div><div class="gmail-h5"><div><div><br><blockquote type="cite"><div>On Nov 9, 2017, at 5:33 PM, <a href="mailto:no-reply@swift.org" target="_blank">no-reply@swift.org</a> wrote:</div><br class="gmail-m_1313309927814604951Apple-interchange-newline"><div><h2 style="font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;width:1069px;background-color:red;color:white;text-align:center">New issue found!</h2><h2 style="font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;width:1069px;background-color:red;color:white;text-align:center"></h2><h1 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">[<font class="gmail-m_1313309927814604951FAILURE" style="color:red">FAILURE</font>] oss-swift-4.1-incremental-RA-<wbr>linux-ubuntu-16_10 [#138]</h1><table style="font-family:"Helvetica Neue",sans-serif;letter-spacing:normal;text-indent:0px;text-transform:none;word-spacing:0px"><tbody><tr style="text-align:left"><th>Build URL:</th><td><a href="https://ci.swift.org/job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/" style="color:rgb(0,122,255);text-decoration:none" target="_blank">https://ci.swift.org/job/oss-<wbr>swift-4.1-incremental-RA-<wbr>linux-ubuntu-16_10/138/</a></td></tr><tr style="text-align:left"><th>Project:</th><td>oss-swift-4.1-incremental-RA-<wbr>linux-ubuntu-16_10</td></tr><tr style="text-align:left"><th>Date of build:</th><td>Thu, 09 Nov 2017 19:16:22 -0600</td></tr><tr style="text-align:left"><th>Build duration:</th><td>16 min</td></tr></tbody></table><h2 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Identified problems:</h2><ul style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><li>Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:<ul><li><a href="https://ci.swift.org//job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/consoleFull#-20360024703122a513-f36a-4c87-8ed7-cbc36a1ec144" style="color:rgb(0,122,255);text-decoration:none" target="_blank">Indication 1</a></li></ul></li></ul><br style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><h2 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Changes</h2><ul style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>97adc5f12e40263ddb9a675<wbr>a02f432c65daaee71</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[MIR] Print target-specific constant pools</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/MIRPrinter.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/MIR/X86/constant-<wbr>pool.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/CodeGen/<wbr>MIRYamlMapping.h</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/CodeGen/MIR/ARM/target-<wbr>constant-pools-error.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/MIRParser/<wbr>MIRParser.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>bebdcae7d9fa45851b2f8a8<wbr>19b6c230115e76490</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[CodeGen] Fix some Clang-tidy modernize and Include What You Use</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/CodeGen/<wbr>MIRYamlMapping.h</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>66210e84c48072979e39cc4<wbr>039c54042131ddab9</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[GlobalISel][X86] G_FCONSTANT support.</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Target/X86/<wbr>X86InstructionSelector.cpp</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/CodeGen/X86/GlobalISel/<wbr>select-fconstant.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Target/X86/<wbr>X86RegisterBankInfo.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Target/X86/<wbr>X86LegalizerInfo.cpp</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/CodeGen/X86/GlobalISel/<wbr>fconstant.ll</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>regbankselect-X86_64.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-constant.mir</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>121242ac03980a7c3ba46a7<wbr>de539694fcbaa2c62</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[GlobalISel][X86] Use correct physical register in mir tests.NFC.</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-ext.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-undef.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-or-scalar.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-add.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-unmerge-vec512.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-and-scalar.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-insert-vec512.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-ext-x86-64.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-phi.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-mul-scalar.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-ext.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-cmp.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>regbankselect-X86_64.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-phi.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-mul-scalar.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-cmp.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-ext-x86-64.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-insert-vec512.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>select-xor-scalar.mir</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>6a3164df8f2c3e6cdd5ad80<wbr>6b5bdc8cfe97dafac</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[GlobalISel][X86] Legalize i1 G_ADD/G_SUB/G_MUL/G_XOR/G_OR/<wbr>G_AND</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-add.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>add-scalar.ll</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/CodeGen/X86/GlobalISel/<wbr>sub-scalar.ll</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Target/X86/<wbr>X86LegalizerInfo.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-and-scalar.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-xor-scalar.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-mul-scalar.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>and-scalar.ll</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>xor-scalar.ll</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-or-scalar.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>legalize-sub.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/X86/GlobalISel/<wbr>or-scalar.ll</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>736be99a0dd878ec734bf7a<wbr>a455906e772ee6be5</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[GlobalISel][X86] refactoring X86InstructionSelector.cpp .NFC.</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Target/X86/<wbr>X86InstructionSelector.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>9881d01abf1a02ca2a2e174<wbr>dfb16a2f49a21e2ef</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Split opt-remark YAML and opt output testing on this test</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/Transforms/GVN/opt-<wbr>remarks.ll</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>13c9ccabd4d81a8ceb36abc<wbr>2bfcf52497a9be844</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Improve comment</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Analysis/<wbr>OptimizationDiagnosticInfo.h</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>42a3c53004c2529fbfcb6e4<wbr>bbe8391880aa6667a</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">This patch fixes <a href="https://bugs.llvm.org/show_bug.cgi?id=32352" style="color:rgb(0,122,255);text-decoration:none" target="_blank">https://bugs.llvm.org/show_<wbr>bug.cgi?id=32352</a> It enables</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/CodeGen/<wbr>MachineOptimizationRemarkEmitt<wbr>er.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: tools/llvm-link/llvm-link.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/IR/LLVMContextImpl.cpp</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: include/llvm/IR/<wbr>DiagnosticHandler.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/IR/DiagnosticInfo.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: tools/llc/llc.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Transforms/Scalar/GVN.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: tools/lto/lto.cpp</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: lib/IR/DiagnosticHandler.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/LTO/Config.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/IR/LLVMContext.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/IR/LLVMContextImpl.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/Transforms/GVN/opt-<wbr>remarks.ll</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: tools/llvm-dis/llvm-dis.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/IR/Core.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Transforms/Vectorize/<wbr>LoopVectorize.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Analysis/<wbr>OptimizationDiagnosticInfo.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/LTO/legacy/<wbr>LTOCodeGenerator.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/LTO/LTOCodeGenerator.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/IR/LLVMContext.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: tools/llvm-lto/llvm-lto.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/IR/<wbr>DiagnosticInfo.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/IR/CMakeLists.txt</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>7e92e11fef4d76d8a9d0411<wbr>5a76a032ae3957548</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Allow ORE.emit to take a closure to delay building the remark object</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/IR/DiagnosticInfo.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/IR/<wbr>DiagnosticInfo.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/IR/<wbr>DiagnosticHandler.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Analysis/<wbr>OptimizationDiagnosticInfo.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/IR/DiagnosticHandler.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>cb23c2b83f82388ede37e1d<wbr>1805c73f35eb6666d</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Fix build for LLVM unittests</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: unittests/Linker/<wbr>LinkModulesTest.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>977c701bfe137665dff3f6d<wbr>09808b71ce40210a2</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[GlobalISel] Only build expensive remarks if they're enabled. NFC.</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/GlobalISel/Utils.<wbr>cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/GlobalISel/<wbr>IRTranslator.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>c94ff728d8d1155a8594e99<wbr>2b0a83dc8fa3fc85d</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[globalisel] Add support for intrinsic_w_chain.</p><ul><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/CodeGen/X86/GlobalISel/<wbr>select-intrinsic-x86-flags-<wbr>read-u32.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Target/<wbr>GlobalISel/SelectionDAGCompat.<wbr>td</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: utils/TableGen/<wbr>GlobalISelEmitter.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>45db2d984b6241c49bdf1a2<wbr>406bec7565f7cac94</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[globalisel] Add support for intrinsic_void</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Target/<wbr>GlobalISel/SelectionDAGCompat.<wbr>td</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/CodeGen/AArch64/<wbr>GlobalISel/select-intrinsic-<wbr>aarch64-hint.mir</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ddb01fed5e7d30f2d372d49<wbr>ce81e3ea1b74f85a8</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[globalisel] Add a G_BSWAP instruction and support bswap using it.</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Target/<wbr>TargetOpcodes.def</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Target/AArch64/<wbr>AArch64LegalizerInfo.cpp</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/CodeGen/AArch64/<wbr>GlobalISel/select-bswap.mir</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Target/<wbr>GenericOpcodes.td</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Target/<wbr>GlobalISel/SelectionDAGCompat.<wbr>td</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>bd502f2f0000a8ebe30f328<wbr>d4e41ed59e8d40368</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[MIRPrinter] Print empty successor lists when they cannot be guessed</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/CodeGen/MIR/ARM/ifcvt_<wbr>canFallThroughTo.mir</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/CodeGen/MIR/X86/<wbr>unreachable_block.ll</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/MIRPrinter.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>213db310e21e19068747166<wbr>2b2e8d238b3273659</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[ARM] Fix some Clang-tidy modernize-use-using and Include What You Use</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Target/ARM/<wbr>ARMCallLowering.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Target/ARM/<wbr>ARMCallLowering.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>eb8a047cbe0a9e2290b1e80<wbr>e561cd9d6ea55a01f</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[GlobalISel] Update the documentation and comments for G_EXTRACT</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: docs/GlobalISel.rst</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Target/<wbr>GenericOpcodes.td</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>a0555e9f3951aea6057c1f1<wbr>74cd3aaa40e9c67c0</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[GlobalISel] Update the documentation for G_SEQUENCE</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: docs/GlobalISel.rst</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ad3f195ed233bce75f1ad91<wbr>5e9d4aadb66427b2a</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[GlobalISel] Update the documentation and comment for G_[UN]MERGE_VALUES</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: docs/GlobalISel.rst</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/llvm/Target/<wbr>GenericOpcodes.td</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>031892702a0314ead57fd9e<wbr>002909caf61205811</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ekarpenko<wbr>v:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Revert "Add _Float16 as a C/C++ source language type"</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Index/USRGeneration.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/AST/StmtPrinter.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/CGExprScalar.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/CGDebugInfo.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Serialization/ASTReader.<wbr>cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Format/FormatToken.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Sema/SemaDecl.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Sema/SemaType.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Sema/SemaExpr.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/clang-c/Index.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/ItaniumCXXABI.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Parse/ParseTentative.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/clang/Lex/<wbr>LiteralSupport.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Lex/LiteralSupport.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/clang/Basic/<wbr>Specifiers.h</li><li class="gmail-m_1313309927814604951change-delete"><b>delete</b>: test/Frontend/float16.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/clang/AST/ASTContext.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/CodeGenTypes.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Parse/ParseExpr.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Serialization/ASTCommon.<wbr>cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Parse/ParseExprCXX.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Sema/SemaTemplateVariadic.<wbr>cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/AST/Type.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/clang/Serialization/<wbr>ASTBitCodes.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/clang/Basic/<wbr>TokenKinds.def</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/AST/TypeLoc.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/AST/MicrosoftMangle.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/AST/ASTContext.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/AST/NSAPI.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Analysis/<wbr>PrintfFormatString.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Parse/ParseDecl.cpp</li><li class="gmail-m_1313309927814604951change-delete"><b>delete</b>: test/CodeGenCXX/float16-<wbr>declarations.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: tools/libclang/CXType.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/AST/ItaniumMangle.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/Sema/DeclSpec.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: test/Lexer/half-literal.cpp</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/clang/Sema/DeclSpec.h</li><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: include/clang/AST/<wbr>BuiltinTypes.def</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>11f34cfdd31ec9552df7fb7<wbr>679064c0375c7f34f</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">This patch fixes <a href="https://bugs.llvm.org/show_bug.cgi?id=32352" style="color:rgb(0,122,255);text-decoration:none" target="_blank">https://bugs.llvm.org/show_<wbr>bug.cgi?id=32352</a> LLVM code</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/CodeGenAction.cpp</li></ul></li><br><li>Commit<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>cae699c147cc75c5eeabf6d<wbr>452384b4ee76fc3f8</b><span class="gmail-m_1313309927814604951Apple-converted-space"> </span>by<span class="gmail-m_1313309927814604951Apple-converted-space"> </span><b>ahmed.<wbr>bougacha:</b><p class="gmail-m_1313309927814604951commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Fix ClangDiagnosticHandler::is*<wbr>RemarkEnabled members</p><ul><li class="gmail-m_1313309927814604951change-edit"><b>edit</b>: lib/CodeGen/CodeGenAction.cpp</li><li class="gmail-m_1313309927814604951change-add"><b>add</b>: test/Frontend/optimization-<wbr>remark-extra-analysis.c</li></ul></li></ul></div></blockquote></div><br></div></div></div></div></div></blockquote></div><br></div></div>