<div><div dir="auto">I think that PR308 on libdispatch should help with that. I don’t have CI rights on that repository though.</div><br><div class="gmail_quote"><div>On Sat, Oct 7, 2017 at 11:40 AM Saleem Abdulrasool via swift-dev <<a href="mailto:swift-dev@swift.org">swift-dev@swift.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Hmm, just so I understand what is going on here ... is there an incompatible change and we aren't rebuilding enough stuff (possibly a missing dependency?) or is there something else going on? Sounds like the swift portion of the build needs to be more aggressively rebuilt?<br></div><div><div class="gmail_extra"><div class="gmail_quote">On Fri, Oct 6, 2017 at 9:57 AM, Jordan Rose <span><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br></div></div></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">+Saleem, who's been looking at Dispatch's build system. <div><div class="m_-5354929585711217032h5"><br><div><br><blockquote type="cite"><div>On Oct 5, 2017, at 22:12, Slava Pestov <<a href="mailto:spestov@apple.com" target="_blank">spestov@apple.com</a>> wrote:</div><br class="m_-5354929585711217032m_1440287044437435455Apple-interchange-newline"><div><div style="word-wrap:break-word;line-break:after-white-space">We keep seeing this failure in the bots:<div><br></div><div>src/libdispatch.so: error: undefined reference to ‘_T0s17_assertionFailures5NeverOs12StaticStringV_SSAE4fileSu4lines6UInt32V5flagstFTfq4nxnnn_n'</div><div><br></div><div>A clean build fixes it. However, it comes back, because if the bot builds the 4.0 branch and then goes and builds master, the problem returns.</div><div><br></div><div>Can somebody look at this?</div><div><br></div><div>Slava<br><div><br><blockquote type="cite"><div>On Oct 5, 2017, at 10:11 PM, <a href="mailto:no-reply@swift.org" target="_blank">no-reply@swift.org</a> wrote:</div><br class="m_-5354929585711217032m_1440287044437435455Apple-interchange-newline"><div><h2 style="font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;width:724px;background-color:red;color:white;text-align:center"></h2><h1 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">[<font class="m_-5354929585711217032m_1440287044437435455FAILURE" style="color:red">FAILURE</font>] oss-swift-incremental-RA-linux-ubuntu-16_04 [#897]</h1><table style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><tbody><tr style="text-align:left"><th>Build URL:</th><td><a href="https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/897/" style="color:rgb(0,122,255);text-decoration:none" target="_blank">https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/897/</a></td></tr><tr style="text-align:left"><th>Project:</th><td>oss-swift-incremental-RA-linux-ubuntu-16_04</td></tr><tr style="text-align:left"><th>Date of build:</th><td>Fri, 06 Oct 2017 00:05:17 -0500</td></tr><tr style="text-align:left"><th>Build duration:</th><td>7 min 26 sec</td></tr></tbody></table><h2 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Identified problems:</h2><ul style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><li>Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:<ul><li><a href="https://ci.swift.org//job/oss-swift-incremental-RA-linux-ubuntu-16_04/897/consoleFull#7382121343122a513-f36a-4c87-8ed7-cbc36a1ec144" style="color:rgb(0,122,255);text-decoration:none" target="_blank">Indication 1</a></li></ul></li></ul><h2 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Tests:</h2><table width="100%" style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><tbody><tr style="text-align:left"><td class="m_-5354929585711217032m_1440287044437435455bg1" colspan="2"></td></tr><tr style="text-align:left"><td class="m_-5354929585711217032m_1440287044437435455bg2" colspan="2">Name:<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>Swift(linux-x86_64)</b><br>Failed: 0 test(s), Passed: 9964 test(s), Total: 9964 test(s)</td></tr><tr style="text-align:left"><td></td></tr><tr style="text-align:left"><td class="m_-5354929585711217032m_1440287044437435455bg2" colspan="2">Name:<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>Swift-Unit</b><br>Failed: 0 test(s), Passed: 483 test(s), Total: 483 test(s)</td></tr><tr style="text-align:left"><td></td></tr></tbody></table><br style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><h2 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Changes</h2><ul style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>c272d41e2f392d2b97c9bd55d819be67912f01d0</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>spestov:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Re-apply "SIL: Remove special meaning for</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/REPL.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/AssertCommon.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/private/StdlibUnittest/StdlibUnittest.swift.gyb</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/Inputs/linker_pass_input.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/Print.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/StringBridge.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/StringComparable.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/string_switch.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/StringSwitch.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/HashedCollections.swift.gyb</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILOptimizer/Utils/Local.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/DebuggerSupport.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SIL/Linker.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/linker.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: docs/HighLevelSILOptimizations.rst</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/StringHashable.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-delete"><b>delete</b>: test/SILOptimizer/specialization_of_stdlib_binary_only.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/public/core/OutputStream.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILOptimizer/IPO/GlobalOpt.cpp</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>5e67f755e044f7a3c143f85c3f1b73d9c1043939</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Remove the -sil-serialize-all option</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/Frontend/CompilerInvocation.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILGen/SILGen.h</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/Serialization/SerializeSIL.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/private/StdlibCollectionUnittest/CMakeLists.txt</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: include/swift/SIL/SILModule.h</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: include/swift/AST/SILOptions.h</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/private/StdlibUnicodeUnittest/CMakeLists.txt</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: include/swift/Option/FrontendOptions.td</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILGen/SILGenType.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/Frontend/Frontend.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: stdlib/private/StdlibUnittest/CMakeLists.txt</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: docs/Lexicon.rst</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/FrontendTool/FrontendTool.cpp</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>dd85e69e7fa36c132a6af0a2abad80ca85127c33</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Update the tests after removing the -sil-serialize-all option</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/Inputs/nontransparent.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/always_inline.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/witnesstable-function-deserialization.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/resilience.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/deserialize_generic.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/perf_inline_without_inline_all.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/visibility.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/noinline.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/witness_tables.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/Inputs/vtable_deserialization_input.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: utils/swift-project-settings.el</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/init_existential_inst_deserializes_witness_tables.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/specializer_can_deserialize.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/sil-func-extractor/load-serialized-sil.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILGen/witness_tables_serialized.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/duplicate_normalprotocolconformance.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/sil-opt/sil-opt.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/basic_sil_objc.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILGen/Inputs/ModuleA.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/default-witness-table-deserialization.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/function_param_convention.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILGen/Inputs/ModuleB.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/basic_sil.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/global_init.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/shared_function_serialization.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/Inputs/def_noinline.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/dead_witness_module.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/Inputs/def_basic.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/serialize_attr.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/projection_lowered_type_parse.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/deserialize_generic_marker.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/Inputs/def_generic_marker.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/specialize_cg_update_crash.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/Inputs/def_generic.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/sil_witness_tables_external_witnesstable.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/linker.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/dead_inlined_func.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/transparent.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/public_external.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILGen/fragile_globals.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/IRGen/sil_witness_tables_external_witnesstable.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/Inputs/def_transparent.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/Inputs/function_param_convention_input.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/sil_partial_apply_ownership.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/sil-serialize-all-with-cross-module-conformance.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/Inputs/shared_function_serialization_input.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/sil_box_types.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/vtable-function-deserialization.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/Inputs/specializer_input.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/vtable_deserialization.swift</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>8e9ce0185225a7adf53c99961401b9b9514fe526</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Remove even more dead code after -sil-serialize-all is gone</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILGen/SILGen.h</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILGen/SILGenType.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: include/swift/SIL/SILModule.h</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILGen/SILGen.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILGen/SILGenGlobalVariable.cpp</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>692575ffb1430ed8dcf12520e230adfe68a93c73</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Remove ResilientStrategy::Fragile</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SIL/SIL.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/Serialization/SerializedModuleLoader.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: include/swift/AST/Module.h</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/AST/Decl.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/IRGen/GenDecl.cpp</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>6c85fff3896e257525eac5b9f696d530989380e2</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Serialize witnesses if -sil-serialize-witness-tables is provided</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILGen/SILGenType.cpp</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>735a22ce089708d2d7460ae2464e09de0a86547c</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Fix serialization of vtables</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/Serialization/SerializeSIL.cpp</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>b13c776d10c05ec999e1a6d12648e60a7f28377a</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Fix a couples of bugs related to witness method serialization</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/IRGen/GenDecl.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/SILGen/SILGenType.cpp</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>9e07d5e0b00f94b82b5dd3f1b388d66351849168</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Remove LinkEntity::isFragile which is always false now.</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/IRGen/GenKeyPath.cpp</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: include/swift/IRGen/Linking.h</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/IRGen/GenDecl.cpp</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>06efb77e4ee87a442b73083149feaaa5ba8e9d00</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Fix tests</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/unmanaged.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/sil-func-extractor/basic.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/Inputs/TestModule.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/opaque_values_serialize.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/basic.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/copy_value_destroy_value.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/sil-nm/basic.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Serialization/Inputs/def_basic.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/bug-reducer-tester-runtime-crasher.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/IRGen/sil_linkage.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/keypath.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/vtable.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/borrow.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/ownership_qualified_memopts.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILGen/witness_tables_serialized.swift</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/sil-func-extractor/basic.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/boxes.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/literals.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/semanticsattr.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SILOptimizer/bug-reducer-tester-miscompile.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/SIL/Serialization/borrow_argument.sil</li><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: test/Driver/emit-sib-single-file.swift</li></ul></li><br><li>Commit<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>154e6c07b3fcf65b55db7513ec07c3b42c463066</b><span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span>by<span class="m_-5354929585711217032m_1440287044437435455Apple-converted-space"> </span><b>rlevenstein:</b><p class="m_-5354929585711217032m_1440287044437435455commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Output all vtables with all their entries if ShouldSerializeAll is true</p><ul><li class="m_-5354929585711217032m_1440287044437435455change-edit"><b>edit</b>: lib/Serialization/SerializeSIL.cpp</li></ul></li></ul></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div></div></blockquote></div></div></div><div><div class="gmail_extra"><div><br></div>-- <br><div class="m_-5354929585711217032gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>
_______________________________________________<br>
swift-dev mailing list<br>
<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-dev</a><br>
</blockquote></div></div><div dir="ltr">-- <br></div><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>