<div dir="ltr">Looks like it wasn't me after all, source compatibility suite still fails in AsyncNinja even with my changes reverted - <a href="https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/391/">https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/391/</a></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 2, 2017 at 6:58 PM, Pavel Yaskevich via swift-dev <span dir="ltr"><<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="im HOEnZb"><div dir="ltr">Jordan, let's see if this helps because when I merged my original PR there were no failures and only one target of AsyncNinja has been disabled, but I noticed (just now) that all of them fail now which might actually not be my fault...</div></span><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 2, 2017 at 6:44 PM, Pavel Yaskevich via swift-dev <span dir="ltr"><<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span><div dir="ltr">Merged revert into master <a href="https://github.com/apple/swift/commit/9642ff0ba6018f5c236186627a3038627ea05a29" target="_blank">https://github.com/appl<wbr>e/swift/commit/9642ff0ba6018f5<wbr>c236186627a3038627ea05a29</a></div></span><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, Oct 2, 2017 at 4:36 PM, Pavel Yaskevich via swift-dev <span dir="ltr"><<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>></span> wrote:<br></span><div><div class="m_7039231132734630304h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><span>Sorry it might be my commit actually, I am AFK for a bit, will revert once I am back.<br><br><div id="m_7039231132734630304m_3582946676495455298m_-3168982883682695835AppleMailSignature">Sent from my iPhone</div><div><br>On Oct 2, 2017, at 3:48 PM, Jordan Rose via swift-dev <<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>> wrote:<br><br></div></span><div><div class="m_7039231132734630304m_3582946676495455298h5"><blockquote type="cite"><div><div>Anton just reupdated AsyncNinja, but it looks we have a new problem there:</div><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div>/Users/buildnode/jenkins/works<wbr>pace-private/swift-master-sour<wbr>ce-compat-suite/project_cache/<wbr>AsyncNinja/Sources/Producer.<wbr>swift:42:27: error: ambiguous use of 'suffix'</div></div><div><div> _bufferedUpdates.push(buffered<wbr>Updates.suffix(bufferSize))</div></div><div><div> ^</div></div><div><div>Swift.Sequence:301:17: note: found this candidate</div></div><div><div> public func suffix(_ maxLength: Int) -> Self.SubSequence</div></div><div><div> ^</div></div><div><div>Swift.Sequence:53:17: note: found this candidate</div></div><div><div> public func suffix(_ maxLength: Int) -> AnySequence<Self.Element></div></div><div><div> ^</div></div></blockquote><div><br></div><div>Pavel, there's already a bug for this, right?</div><div><br></div><div>Jordan<br class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-interchange-newline"><br></div><br><div><br><blockquote type="cite"><div>On Oct 2, 2017, at 15:44, <a href="mailto:no-reply@swift.org" target="_blank">no-reply@swift.org</a> wrote:</div><br class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-interchange-newline"><div><h2 style="font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;width:845px;background-color:red;color:white;text-align:center"></h2><h1 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">[<font class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835FAILURE" style="color:red">FAILURE</font>] swift-master-source-compat-sui<wbr>te [#389]</h1><table style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><tbody><tr style="text-align:left"><th>Build URL:</th><td><a href="https://ci.swift.org/job/swift-master-source-compat-suite/389/" style="color:rgb(0,122,255);text-decoration:none" target="_blank">https://ci.swift.org/job/swift<wbr>-master-source-compat-suite/38<wbr>9/</a></td></tr><tr style="text-align:left"><th>Project:</th><td>swift-master-source-compat-sui<wbr>te</td></tr><tr style="text-align:left"><th>Date of build:</th><td>Mon, 02 Oct 2017 15:15:01 -0500</td></tr><tr style="text-align:left"><th>Build duration:</th><td>2 hr 30 min</td></tr></tbody></table><br style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><h2 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Changes</h2><ul style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>001b09747a153763b30ef8a<wbr>02254c7a0419c6292</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>pyaskevic<wbr>h:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[ConstraintSolver] Prioritize certain type variables while looking for</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: test/Constraints/generics.swif<wbr>t</li><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: lib/Sema/CSSimplify.cpp</li><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: lib/Sema/CSBindings.cpp</li><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: lib/Sema/ConstraintSystem.h</li></ul></li><br><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>6fe4ff8be7ab142ba7427c6<wbr>65b955770fc6905ba</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>mnvrth:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[CMake] Fix status message when not building stdlib/runtime</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: CMakeLists.txt</li></ul></li><br><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>5ba1522874a46b85df8de7c<wbr>d6bd4f4d1d41ab4a7</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>mnvrth:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[CMake] Improve wording of stdlib/overlay/runtime build status</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: CMakeLists.txt</li></ul></li><br><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>f2ef42baed96e1608648153<wbr>7cc7dc87bbd2368b0</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>github:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[migrator] When renaming a function decl, we should use underscore to</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: lib/Migrator/APIDiffMigratorPa<wbr>ss.cpp</li><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: test/Migrator/Inputs/Cities.sw<wbr>ift</li><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: test/Migrator/rename-func-decl<wbr>.swift</li><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: test/Migrator/rename-func-decl<wbr>.swift.expected</li><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: test/Migrator/Inputs/API.json</li></ul></li><br><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>c47287199bce9b4d2c9ae0d<wbr>c308dc328461ce9f6</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>arthur:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Updated Guitar support for Swift 4.0</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: projects.json</li></ul></li><br><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>1a82e4d490d4607da81f583<wbr>27eb0f900f3056c08</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>antonvmir<wbr>onov:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">AsyncNinja updated. <a href="https://bugs.swift.org/browse/SR-5998" style="color:rgb(0,122,255);text-decoration:none" target="_blank">https://bugs.swift.org/browse/<wbr>SR-5998</a> fixed</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: projects.json</li></ul></li><br><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>ce4cf094fabf5b5e306b6b7<wbr>b5cf65461ab681d7b</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>arthur:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Re-added 3.1 compatibility</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: projects.json</li></ul></li><br><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>632bf4e2201eb4d2d3cfb9a<wbr>594f02e4bfc5f6a3a</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>arthur:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">Removed comma</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: projects.json</li></ul></li><br><li>Commit<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>87ebe010aedc3bd89d351f8<wbr>b0ecc7ffdd0ea8494</b><span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span>by<span class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835Apple-converted-space"> </span><b>antonvmir<wbr>onov:</b><p class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">UnXFAIL AsyncNinja</p><ul><li class="m_7039231132734630304m_3582946676495455298m_-3168982883682695835change-edit"><b>edit</b>: projects.json</li></ul></li></ul></div></blockquote></div><br></div></blockquote></div></div><span><blockquote type="cite"><div><span>______________________________<wbr>_________________</span><br><span>swift-dev mailing list</span><br><span><a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a></span><br><span><a href="https://lists.swift.org/mailman/listinfo/swift-dev" target="_blank">https://lists.swift.org/mailma<wbr>n/listinfo/swift-dev</a></span><br></div></blockquote></span></div><br>______________________________<wbr>_________________<br>
swift-dev mailing list<br>
<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailma<wbr>n/listinfo/swift-dev</a><br>
<br></blockquote></div></div></div><br></div>
<br>______________________________<wbr>_________________<br>
swift-dev mailing list<br>
<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailma<wbr>n/listinfo/swift-dev</a><br>
<br></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
swift-dev mailing list<br>
<a href="mailto:swift-dev@swift.org">swift-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-dev</a><br>
<br></blockquote></div><br></div>