<div dir="ltr">PR#11994<div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 18, 2017 at 7:13 PM, Saleem Abdulrasool via swift-dev <span dir="ltr"><<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><span class="gmail-">Ugh, I think I see what the issue is. The build-script-impl wrapper is pretty intricate and I missed the conditional check since it was pretty similar to the one near it. I guess the test for the original change didnt notice it due to caching effects. I'll have a fix up for this momentarily.<br></span><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Mon, Sep 18, 2017 at 6:59 PM, Saleem Abdulrasool via swift-dev <span dir="ltr"><<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>></span> wrote:<br></span><div><div class="gmail-h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span><div dir="ltr">Yeah, Im looking into this. That is a really weird error. It seems like it would be related to the the switch to CMake for libdispatch.</div></span><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, Sep 18, 2017 at 6:34 PM, Vedant Kumar via swift-dev <span dir="ltr"><<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div><div class="gmail-m_130547339444260624h5"><div style="word-wrap:break-word"><span>I don't think I have changed this or control it:</span><pre style="word-wrap:break-word;white-space:pre-wrap">--install-destdir is required to install products.
/home/buildnode/jenkins/worksp<wbr>ace/oss-swift-incremental-RA-l<wbr>inux-ubuntu-16_04/swift/utils/<wbr>build-script: fatal error: command terminated with a non-zero exit status 1, aborting
/home/buildnode/jenkins/worksp<wbr>ace/oss-swift-incremental-RA-l<wbr>inux-ubuntu-16_04/swift/utils/<wbr>build-script: fatal error: command terminated with a non-zero exit status 1, aborting</pre><div><br></div><div>vedant</div><div><br></div><div><blockquote type="cite"><div>On Sep 18, 2017, at 6:32 PM, <a href="mailto:no-reply@swift.org" target="_blank">no-reply@swift.org</a> wrote:</div><br class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-interchange-newline"><div><h2 style="font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;width:1231px;background-color:red;color:white;text-align:center">New issue found!</h2><h2 style="font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;width:1231px;background-color:red;color:white;text-align:center"></h2><h1 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">[<font class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261FAILURE" style="color:red">FAILURE</font>] oss-swift-incremental-RA-linux<wbr>-ubuntu-16_04 [#596]</h1><table style="font-family:"Helvetica Neue",sans-serif;letter-spacing:normal;text-indent:0px;text-transform:none;word-spacing:0px"><tbody><tr style="text-align:left"><th>Build URL:</th><td><a href="https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/596/" style="color:rgb(0,122,255);text-decoration:none" target="_blank">https://ci.swift.org/job/oss-s<wbr>wift-incremental-RA-linux-ubun<wbr>tu-16_04/596/</a></td></tr><tr style="text-align:left"><th>Project:</th><td>oss-swift-incremental-RA-linux<wbr>-ubuntu-16_04</td></tr><tr style="text-align:left"><th>Date of build:</th><td>Mon, 18 Sep 2017 19:25:52 -0500</td></tr><tr style="text-align:left"><th>Build duration:</th><td>1 hr 7 min</td></tr></tbody></table><h2 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Tests:</h2><table width="100%" style="font-family:"Helvetica Neue",sans-serif;letter-spacing:normal;text-indent:0px;text-transform:none;word-spacing:0px"><tbody><tr style="text-align:left"><td class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261bg1" colspan="2"></td></tr><tr style="text-align:left"><td class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261bg2" colspan="2">Name:<span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span><b>Swift(linux-x86_64)</b><br>Failed: 0 test(s), Passed: 9899 test(s), Total: 9899 test(s)</td></tr><tr style="text-align:left"><td></td></tr><tr style="text-align:left"><td class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261bg2" colspan="2">Name:<span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span><b>Swift-Unit</b><br>Failed: 0 test(s), Passed: 461 test(s), Total: 461 test(s)</td></tr><tr style="text-align:left"><td></td></tr></tbody></table><br style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><h2 style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-style:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Changes</h2><ul style="color:rgb(57,57,57);font-family:"Helvetica Neue",sans-serif;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:300;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><li>Commit<span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span><b>7e0311ad2cf4f688518aed8<wbr>4a665b6c8a50eaefc</b><span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span>by<span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span><b>vsk:</b><p class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[Coverage] Use gap regions to select better line exec counts</p><ul><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: include/llvm/ProfileData/Instr<wbr>ProfData.inc</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: tools/llvm-cov/SourceCoverageV<wbr>iewText.cpp</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: lib/ProfileData/Coverage/Cover<wbr>ageMappingReader.cpp</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: lib/ProfileData/Coverage/Cover<wbr>ageMapping.cpp</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: docs/CoverageMappingFormat.rst</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: tools/llvm-cov/SourceCoverageV<wbr>iewHTML.cpp</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: tools/llvm-cov/SourceCoverageV<wbr>iew.cpp</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: include/llvm/ProfileData/Cover<wbr>age/CoverageMapping.h</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: test/tools/llvm-cov/deferred-r<wbr>egion.cpp</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: lib/ProfileData/Coverage/Cover<wbr>ageMappingWriter.cpp</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: test/tools/llvm-cov/Inputs/def<wbr>erred-regions.covmapping</li></ul></li><br><li>Commit<span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span><b>9a8caaf5b6cd207d61e0867<wbr>ea46650d45a3e5adf</b><span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span>by<span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span><b>vsk:</b><p class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[profile] Update InstrProfData.inc</p><ul><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: lib/profile/InstrProfData.inc</li></ul></li><br><li>Commit<span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span><b>223e2eacb73b51efd6284bf<wbr>b15ac1ef9b596a2e6</b><span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span>by<span class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261Apple-converted-space"> </span><b>vsk:</b><p class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261commit-message" style="font-family:Menlo,fixed;white-space:pre-wrap">[cmake] Make it possible to build and test profile without sanitizers</p><ul><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: lib/CMakeLists.txt</li><li class="gmail-m_130547339444260624m_5429257710155194004m_-74877454884952261change-edit"><b>edit</b>: test/CMakeLists.txt</li></ul></li></ul></div></blockquote></div><br></div><br></div></div><span>______________________________<wbr>_________________<br>
swift-dev mailing list<br>
<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailma<wbr>n/listinfo/swift-dev</a><br>
<br></span></blockquote></div><span><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_130547339444260624m_5429257710155194004gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</span></div>
<br>______________________________<wbr>_________________<br>
swift-dev mailing list<br>
<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailma<wbr>n/listinfo/swift-dev</a><br>
<br></blockquote></div></div></div><div><div class="gmail-h5"><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_130547339444260624gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div></div></div>
<br>______________________________<wbr>_________________<br>
swift-dev mailing list<br>
<a href="mailto:swift-dev@swift.org">swift-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>