<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Slava,<div class=""><br class=""></div><div class="">Thanks! I appreciate the suggestion to run tests, but what I’ve tried in the past, @swift-ci ignored me. Is there a whitelist for who can request that tests be run? That would make sense from a security perspective.<div class=""><br class=""></div><div class="">Dave</div><div class=""><br class=""><div class=""><br class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 8, 2017, at 23:48, Slava Pestov <<a href="mailto:spestov@apple.com" class="">spestov@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I see you’re two steps ahead of me already: <a href="https://github.com/apple/swift/pull/11397" class="">https://github.com/apple/swift/pull/11397</a><div class=""><br class=""></div><div class="">This looks good, nice catch!</div><div class=""><br class=""></div><div class="">Slava</div><div class=""><br class=""><div style="" class=""><blockquote type="cite" class=""><div class="">On Aug 8, 2017, at 8:45 PM, Slava Pestov <<a href="mailto:spestov@apple.com" class="">spestov@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class=""><blockquote type="cite" class="">On Aug 8, 2017, at 3:34 PM, David Zarzycki via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:<br class=""><br class="">In ConstraintSystem::performMemberLookup(), constructors with “simple” names have a dedicated lookup path. In contrast, constructors with compound names are handled by the normal lookup. If I delete this code and let the normal lookup path handle both simple and compound named constructors, I find that all 10,214 validation tests pass on my machine (albeit with slightly different error messages in three test files).<br class=""></blockquote><br class="">I would suggest running the source compatibility test suite also (see “pull request testing” in <a href="https://swift.org/source-compatibility/" class="">https://swift.org/source-compatibility/</a>), but it is quite possible the code is indeed unnecessary.<br class=""><br class=""><blockquote type="cite" class=""><br class="">Is the test suite missing a test for this code path and if so, what? Or should it be scheduled for deletion after identical error messages can be generated by the normal lookup path?<br class=""></blockquote><br class="">Are the new error messages worse or just different? If the latter there’s really no requirement to keep them identical.<br class=""><br class="">Slava<br class=""><br class=""><blockquote type="cite" class=""><br class="">Dave<br class="">_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class=""></blockquote><br class=""></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></div></div></body></html>