<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Mark do you have suggestions for Dave?<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 9, 2017, at 11:22 AM, David Zarzycki via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Any tips on how to debug performance regressions?<div class=""><br class=""></div><div class="">And as aside, if this test is critical enough to cause a revert, why isn’t it in the public repo?</div><div class=""><div class=""><br class=""></div></div></div></div></blockquote><div><br class=""></div>This is part of a larger internal test.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class=""><div class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 9, 2017, at 14:04, Arnold Schwaighofer <<a href="mailto:notifications@github.com" class="">notifications@github.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p class="">Hi Dave,<br class="">
I have reverted this commit because it broke internal bots.</p>
<pre class=""><code class="">import Foundation
class P {
var x : Int = 0
var y : Int = 1
}
let dist : (P, P) -> Double = {
(p : P, s : P) -> Double in
sqrt(Double((p.x-s.x)*(p.x-s.x) + (p.y-s.y)*(p.y-s.y)))
}
</code></pre><p class="">fails now with expression to complex.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;" class="">—<br class="">You are receiving this because you authored the thread.<br class="">Reply to this email directly, <a href="https://github.com/apple/swift/pull/11397#issuecomment-321334844" class="">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABBbbrS4O6QyW6_j4ksVB-fo2EPtmbWVks5sWfSigaJpZM4Oxfg-" class="">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABBbbpGHltnRTuyP1p8I4EpU_ZYh8rm2ks5sWfSigaJpZM4Oxfg-.gif" width="1" class=""></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage" class="">
<div itemprop="action" itemscope="" itemtype="http://schema.org/ViewAction" class="">
<link itemprop="url" href="https://github.com/apple/swift/pull/11397#issuecomment-321334844" class="">
<meta itemprop="name" content="View Pull Request" class="">
</div>
<meta itemprop="description" content="View this Pull Request on GitHub" class="">
</div>
<script type="application/json" data-scope="inboxmarkup" class="">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/apple/swift","title":"apple/swift","subtitle":"GitHub repository","main_image_url":"<a href="<a href="https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png" class="">https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png</a>" class=""><a href="https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png" class="">https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png</a></a>","avatar_image_url":"<a href="<a href="https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png" class="">https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png</a>" class=""><a href="https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png" class="">https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png</a></a>","action":{"name":"Open in GitHub","url":"<a href="<a href="https://github.com/apple/swift" class="">https://github.com/apple/swift</a>" class=""><a href="https://github.com/apple/swift" class="">https://github.com/apple/swift</a></a>"}},"updates":{"snippets":[{"icon":"PERSON","message":"@aschwaighofer in #11397: Hi Dave,\r\nI have reverted this commit because it broke internal bots. \r\n```\r\nimport Foundation\r\nclass P {\r\n var x : Int = 0\r\n var y : Int = 1\r\n}\r\n\r\nlet dist : (P, P) -\u003e Double = {\r\n (p : P, s : P) -\u003e Double in\r\n sqrt(Double((p.x-s.x)*(p.x-s.x) + (p.y-s.y)*(p.y-s.y)))\r\n}\r\n```\r\nfails now with expression to complex."}],"action":{"name":"View Pull Request","url":"<a href="<a href="https://github.com/apple/swift/pull/11397#issuecomment-321334844" class="">https://github.com/apple/swift/pull/11397#issuecomment-321334844</a>" class=""><a href="https://github.com/apple/swift/pull/11397#issuecomment-321334844" class="">https://github.com/apple/swift/pull/11397#issuecomment-321334844</a></a>"}}}</script></div></blockquote></div><br class=""></div></div></div></div></div>_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-dev<br class=""></div></blockquote></div><br class=""></div></body></html>