<div dir="ltr"><div>Hi Andrew, </div><div><br></div>I wrote the draft of this e-mail few weeks ago, and the following sentence is not true:<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Its emitted when the new MIN falls inside the (MIN..MAX) range of the OLD baseline. It is not checked the other way around.</div></div></div></blockquote><div><div>See below...</div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 13, 2017 at 1:45 AM, Pavol Vaskovic <span dir="ltr">&lt;<a href="mailto:pali@pali.sk" target="_blank">pali@pali.sk</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Andrew,<div><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Mon, Jun 12, 2017 at 11:55 PM, Andrew Trick <span dir="ltr">&lt;<a href="mailto:atrick@apple.com" target="_blank">atrick@apple.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><div><div class="gmail-m_1786905750201933979gmail-h5"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>To partially address this issue (I&#39;m guessing) the last SPEEDUP column sometimes features mysterious question mark in brackets. Its emitted when the new MIN falls inside the (MIN..MAX) range of the OLD baseline. It is not checked the other way around.<br></div></div></div></div></blockquote><div><br></div></div></div><div>That bug must have been introduced during one of the rewrites. Is that in the driver or compare script? Why not fix that bug?</div></div></div></blockquote><div><br></div></span><div>That is in the compare script. It looks like the else branch got lost <a href="https://github.com/apple/swift/commit/cb23837bb932f21b61d2a79c936d88c167fd91d0#diff-5ca4ab28608a4259eff23c72eed7ae8d" target="_blank">during a rewrite</a> (search for &quot;(?)&quot; in that diff). I could certainly fix that too, but I&#39;m not sure that would be enough to fix all our problems.</div></div></div></div></div></blockquote><div><br></div><div> I even <a href="https://github.com/apple/swift/blob/686c7619922d0de2bfdb3a0ec988b2c3c6bb60b5/benchmark/scripts/test_compare_perf_tests.py#L162">wrote tests for this</a>, and my implementation is <a href="https://github.com/apple/swift/blob/e7b243cad7e27af63e6c25cd426fdc5359c4e51d/benchmark/scripts/compare_perf_tests.py#L135">pretty clear too</a>… somehow I forgot this.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"># Add &#39; (?)&#39; to the speedup column as indication of dubious changes:</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"># result&#39;s MIN falls inside the (MIN, MAX) interval of result they are</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"># being compared with.</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">self.is_dubious = (</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">    &#39; (?)&#39; if ((old.min &lt; new.min and new.min &lt; old.max) or</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">               (new.min &lt; old.min and old.min &lt; new.max))</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">    else &#39;&#39;)</blockquote></blockquote><div><br></div><div>I&#39;m sorry for the confusion. </div><div><br></div><div>--Pavol</div></div></div></div></div></div>