<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Oh.. I did not. It was for another PR. False alarm.<div class=""><br class=""></div><div class="">This PR fixes the problem: <a href="https://github.com/apple/swift/pull/9560" class="">https://github.com/apple/swift/pull/9560</a><br class=""><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 12, 2017, at 5:47 PM, Luke Larson <<a href="mailto:llarson@apple.com" class="">llarson@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Where did you run the compatibility suite on the pull request?<div class=""><br class=""></div><div class="">Luke</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On May 12, 2017, at 5:46 PM, Luke Larson <<a href="mailto:llarson@apple.com" class="">llarson@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">It’s the same test suite.<div class=""><br class=""></div><div class="">Luke</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On May 12, 2017, at 5:34 PM, Max Moiseev <<a href="mailto:moiseev@apple.com" class="">moiseev@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Missing String.init?(_:String) in an expression:<div class=""><br class=""></div><div class="">String.init(value)!</div><div class=""><br class=""></div><div class="">where value is of type String.</div><div class=""><br class=""></div><div class="">Due to my changes that passed the PR compatibility testing…</div><div class="">Luke, isn’t it the same test suite?</div><div class=""><br class=""></div><div class="">Max</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On May 12, 2017, at 5:17 PM, <a href="mailto:no-reply@swift.org" class="">no-reply@swift.org</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><h2 style="font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; width: 938px; background-color: red; color: white; text-align: center;" class=""></h2><h1 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">[<font class="FAILURE" style="color: red;">FAILURE</font>] swift-master-source-compat-suite [#283]</h1><table style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><th class="">Build URL:</th><td class=""><a href="https://ci.swift.org/job/swift-master-source-compat-suite/283/" style="color: rgb(0, 122, 255); text-decoration: none;" class="">https://ci.swift.org/job/swift-master-source-compat-suite/283/</a></td></tr><tr style="text-align: left;" class=""><th class="">Project:</th><td class="">swift-master-source-compat-suite</td></tr><tr style="text-align: left;" class=""><th class="">Date of build:</th><td class="">Fri, 12 May 2017 15:45:48 -0700</td></tr><tr style="text-align: left;" class=""><th class="">Build duration:</th><td class="">1 hr 31 min</td></tr></tbody></table><br style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Changes</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">4e9851b032b1ae351bb80854fcdb7fc943a90cad</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">Joe Groff:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Don't classify bridging casts as WillSucceed if the object-to-value cast</p><ul class=""><li class="change-add"><b class="">add</b>: test/SILOptimizer/cast_folding_objc_bridging_conditional.sil</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckType.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILOptimizer/Utils/Local.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckConstraints.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/CSSimplify.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeChecker.h</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/ASTContext.h</li><li class="change-edit"><b class="">edit</b>: lib/AST/ASTContext.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SIL/DynamicCasts.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">46415e7dbd55b43d6655dd6f88a9c6ce4445b5e0</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">Max Moiseev:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[stdlib] Removing a String.init?(_: String), non-failable is enough</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/core/String.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">9a9d1393208fbd581b49d9e855e4288e748abcfa</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">github:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[ClangImporter] Import Swift 3 and 4 names for enumerators. (#9523)</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/ClangImporter/ImportName.cpp</li><li class="change-edit"><b class="">edit</b>: lib/ClangImporter/SwiftLookupTable.h</li><li class="change-edit"><b class="">edit</b>: lib/ClangImporter/ImportDecl.cpp</li><li class="change-edit"><b class="">edit</b>: test/APINotes/versioned.swift</li><li class="change-edit"><b class="">edit</b>: lib/ClangImporter/ImportName.h</li><li class="change-edit"><b class="">edit</b>: test/APINotes/Inputs/custom-frameworks/APINotesFrameworkTest.framework/Headers/APINotesFrameworkTest.h</li><li class="change-edit"><b class="">edit</b>: test/APINotes/Inputs/custom-frameworks/APINotesFrameworkTest.framework/Headers/APINotesFrameworkTest.apinotes</li><li class="change-add"><b class="">add</b>: test/APINotes/Inputs/custom-frameworks/APINotesFrameworkTest.framework/Headers/Enums.h</li></ul></li></ul></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></body></html>