<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks! <div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 6, 2017, at 3:32 PM, Jordan Rose <<a href="mailto:jordan_rose@apple.com" class="">jordan_rose@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">Erik may have beat you to it. <a href="https://github.com/apple/swift/pull/8595" class="">https://github.com/apple/swift/pull/8595</a></div><div class=""><br class=""></div><div class="">Jordan</div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Apr 6, 2017, at 15:18, mishal_shah via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Looks like this was cherry-picked in swift-clang without PR testing.<div class=""><br class=""></div><div class="">Thanks,</div><div class="">Mishal Shah<br class=""><div class=""><blockquote type="cite" class=""><div class="">On Apr 6, 2017, at 3:17 PM, Slava Pestov <<a href="mailto:spestov@apple.com" class="">spestov@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I have a fix pending in this PR: <a href="https://github.com/apple/swift/pull/8594" class="">https://github.com/apple/swift/pull/8594</a><div class=""><br class=""></div><div class="">But I’m surprised this wasn’t caught in CI.</div><div class=""><br class=""></div><div class="">Slava</div><div class=""><br class=""><div style="" class=""><blockquote type="cite" class=""><div class="">On Apr 6, 2017, at 2:58 PM, Mishal Shah <<a href="mailto:mishal_shah@apple.com" class="">mishal_shah@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Slave, <div class=""><br class=""></div><div class="">This started after following commits:</div><div class=""><br class=""></div><div class=""><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/" class="">https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/</a></div><div class=""><p style="box-sizing: border-box; font-family: Helvetica, Arial, sans-serif; font-size: 14px; line-height: 1.4em; -webkit-font-smoothing: antialiased; color: rgb(51, 51, 51);" class="">Git (clang)</p><ol style="box-sizing: border-box; color: rgb(51, 51, 51); font-family: Helvetica, Arial, sans-serif; font-size: 13px;" class=""><li style="box-sizing: border-box;" class="">Change -ffp-contract=fast test to run on Aarch64 (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li><li style="box-sizing: border-box;" class="">Remove -ffp-contract=fast from this test (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li><li style="box-sizing: border-box;" class="">Encapsulate FPOptions and use it consistently (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li><li style="box-sizing: border-box;" class="">Use FPContractModeKind universally (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li><li style="box-sizing: border-box;" class="">Use 'unsigned' for enum bitfields (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li><li style="box-sizing: border-box;" class="">Set FMF for -ffp-contract=fast (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li><li style="box-sizing: border-box;" class="">Add #pragma clang fp (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li><li style="box-sizing: border-box;" class="">Fix sphinx warning from r299470 (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li><li style="box-sizing: border-box;" class="">Another attempt to fix the sphinx warning from r299470 (<a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail" style="box-sizing: border-box; color: rgb(50, 108, 166) !important; text-decoration: none !important;" class="">detail</a><j:text xmlns:j="jelly:core" style="box-sizing: border-box;" class="">)</j:text></li></ol><div class=""><br class=""></div><div class="">Thanks, </div><div class="">Mishal Shah</div><div class=""><blockquote type="cite" class=""><div class="">On Apr 6, 2017, at 2:53 PM, Slava Pestov via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi all,<br class=""><br class="">I’m hitting this in github PR testing:<br class=""><br class="">/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/lib/ClangImporter/ImportDecl.cpp:994:34: error: no matching constructor for initialization of 'clang::BinaryOperator'<br class=""><br class=""> auto cSetterExpr = new (Ctx) clang::BinaryOperator(cSetterMemberExpr,<br class=""> ^ ~~~~~~~~~~~~~~~~~~<br class="">/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:2929:3: note: candidate constructor not viable: no known conversion from 'bool' to 'clang::FPOptions' for 8th argument<br class=""> BinaryOperator(Expr *lhs, Expr *rhs, Opcode opc, QualType ResTy,<br class=""> ^<br class="">/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:3085:3: note: candidate constructor not viable: requires 9 arguments, but 8 were provided<br class=""> BinaryOperator(Expr *lhs, Expr *rhs, Opcode opc, QualType ResTy,<br class=""> ^<br class="">/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:3100:3: note: candidate constructor not viable: requires 2 arguments, but 8 were provided<br class=""> BinaryOperator(StmtClass SC, EmptyShell Empty)<br class=""> ^<br class="">/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:2947:12: note: candidate constructor not viable: requires single argument 'Empty', but 8 arguments were provided<br class=""> explicit BinaryOperator(EmptyShell Empty)<br class=""> ^<br class="">/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:2913:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 8 were provided<br class="">class BinaryOperator : public Expr {<br class=""> ^<br class="">/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:2913:7: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 8 were provided<br class="">1 error generated.<br class=""><br class="">Is there a Clang/LLVM merge in progress or something?<br class=""><br class="">Slava<br class="">_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class=""></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class=""></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></body></html>