<div dir="ltr">Ah I see. I've sent in <a href="https://github.com/apple/swift/pull/8529">https://github.com/apple/swift/pull/8529</a><div><br></div><div>Thanks</div><div>Hugh</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 4 April 2017 at 10:57, mishal_shah <span dir="ltr"><<a href="mailto:mishal_shah@apple.com" target="_blank">mishal_shah@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">We need to cherry-pick this fix (PR#8384) into swift-4.0-branch to avoid python lint failure. <div><div><br></div><div>Thanks,</div><div>Mishal Shah<div><div class="h5"><br><div><blockquote type="cite"><div>On Apr 3, 2017, at 8:17 PM, Hugh Bellamy <<a href="mailto:hughbellars@gmail.com" target="_blank">hughbellars@gmail.com</a>> wrote:</div><br class="m_2874186701482012075Apple-interchange-newline"><div><div dir="ltr">This issue was fixed in <a href="https://github.com/apple/swift/pull/8384" target="_blank">https://github.com/apple/<wbr>swift/pull/8384</a>, I think.</div><div class="gmail_extra"><br><div class="gmail_quote">On 4 April 2017 at 06:31, Vedant Kumar <span dir="ltr"><<a href="mailto:vsk@apple.com" target="_blank">vsk@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This doesn't look related to my changes.<br>
<br>
+ Hugh, since he's at least touched the file.<br>
<br>
vedant<br>
<br>
> On Apr 3, 2017, at 4:29 PM, <a href="mailto:no-reply@swift.org" target="_blank">no-reply@swift.org</a> wrote:<br>
><br>
> [FAILURE] oss-swift-4.0-incremental-RA-o<wbr>sx [#71]<br>
><br>
> Build URL: <a href="https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/71/" rel="noreferrer" target="_blank">https://ci.swift.org/job/oss-s<wbr>wift-4.0-incremental-RA-osx/71<wbr>/</a><br>
> Project: oss-swift-4.0-incremental-RA-o<wbr>sx<br>
> Date of build: Mon, 03 Apr 2017 15:39:24 -0700<br>
> Build duration: 49 min<br>
> Identified problems:<br>
><br>
> • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:<br>
> • Indication 1<br>
> Tests:<br>
><br>
> Name: Swift(macosx-x86_64)<br>
> Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)<br>
> • Failed: Swift(macosx-x86_64).Python.gy<wbr>b.swift<br>
> Name: Swift-Unit<br>
> Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)<br>
><br>
> Changes<br>
><br>
> • Commit f683c24ef812b985e0e93c0aaa9620<wbr>62677b0af4 by Vedant Kumar:<br>
> Revert "[InlineCost] Fix codesize issue caused by r286814"<br>
><br>
> • edit: test/Transforms/Inline/inline-<wbr>fast-math-flags.ll<br>
> • edit: test/Transforms/Inline/optimiz<wbr>ation-remarks-passed-yaml.ll<br>
> • edit: test/Transforms/Inline/inline-<wbr>cold.ll<br>
> • edit: test/Transforms/Inline/inline-<wbr>hot-callee.ll<br>
> • edit: lib/Analysis/InlineCost.cpp<br>
> • edit: test/Transforms/Inline/inline-<wbr>cold-callee.ll<br>
> • edit: test/Transforms/Inline/inline-<wbr>optsize.ll<br>
> • edit: test/Transforms/Inline/alloca-<wbr>bonus.ll<br>
> • edit: test/Transforms/Inline/ptr-dif<wbr>f.ll<br>
> • edit: test/Transforms/Inline/inline-<wbr>hot-callsite.ll<br>
> • edit: test/Transforms/Inline/inline_<wbr>unreachable-2.ll<br>
><br>
> • Commit 57278f9a2b853e79b47aaff61b25a9<wbr>52aade98f8 by Vedant Kumar:<br>
> Revert "[Inliner] Tweak inline threshold for code size regression"<br>
><br>
> • edit: test/Transforms/Inline/ptr-dif<wbr>f.ll<br>
><br>
> • Commit e3511601a3c036006fab2becb4802b<wbr>8f27055f02 by Vedant Kumar:<br>
> Revert "[InlineCost] Remove skew when calculating call costs"<br>
><br>
> • edit: test/Transforms/Inline/inline_<wbr>unreachable-2.ll<br>
> • edit: test/Transforms/Inline/ptr-dif<wbr>f.ll<br>
> • edit: test/Transforms/Inline/optimiz<wbr>ation-remarks-passed-yaml.ll<br>
> • edit: test/Transforms/Inline/inline-<wbr>hot-callsite.ll<br>
> • edit: test/Transforms/Inline/inline-<wbr>optsize.ll<br>
> • edit: test/Transforms/Inline/inline-<wbr>cold.ll<br>
> • edit: test/Transforms/Inline/alloca-<wbr>bonus.ll<br>
> • edit: lib/Analysis/InlineCost.cpp<br>
> • edit: test/Transforms/Inline/inline-<wbr>cold-callee.ll<br>
> • edit: test/Transforms/Inline/inline-<wbr>hot-callee.ll<br>
><br>
> • Commit 022afe34b9c86521a7d17bcd75811b<wbr>6f1c39daba by Vedant Kumar:<br>
> Revert "[InlineCost] Reduce inline thresholds to compensate for cost<br>
><br>
> • edit: test/Transforms/Inline/inline-<wbr>fp.ll<br>
> • edit: include/llvm/Analysis/InlineCo<wbr>st.h<br>
> • edit: test/Transforms/Inline/ephemer<wbr>al.ll<br>
<br>
</blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></div></blockquote></div><br></div>