<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 27, 2017, at 1:10 PM, Pavol Vaskovic via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi!<div class=""><br class=""></div><div class="">I’d like to create my first full request (as requested by Jordan Rose in <a class="gmail-issue-link" href="https://bugs.swift.org/browse/SR-4373" id="gmail-key-val" rel="14852" style="font-family:arial,sans-serif;font-size:14px;color:rgb(59,115,175);text-decoration:none">SR-4373</a>), but I didn’t find enough information about how to proceed on the Swift’s Contributing page, nor during my googling.</div><div class=""><br class=""></div><div class="">I am not very familiar with git/github outside of browsing and checking out code.</div><div class=""><br class=""></div><div class="">So far I have completed the "Getting Started” steps:</div><div class="">* checked out the swift-source</div><div class="">* got it to compile on my machine (debug and release)</div><div class="">* manually ran benchmark suite (filed <a class="gmail-issue-link" href="https://bugs.swift.org/browse/SR-4357" id="gmail-key-val" rel="14836" style="font-family:arial,sans-serif;font-size:14px;color:rgb(59,115,175);text-decoration:none">SR-4357</a>, BTW what does SR for?)</div><div class=""><br class=""></div><div class="">Now the <a href="https://swift.org/contributing/#contributing-code" class="">Contributing to Swift guide</a> left me hanging dry. I don’t understand what should I do now.</div><div class=""><br class=""></div><div class="">I think I should fork the apple/swift project on GitHub.It looks like the update-checkout script can be configured using update-checkout-config.json… is this where I point it to my fork?</div><div class=""><br class=""></div><div class="">I guess I should create a branch where I’ll develop my changes and then create a pull request from there? (I’ve skimmed <a href="https://help.github.com/articles/creating-a-pull-request-from-a-fork/" class="">https://help.github.com/articles/creating-a-pull-request-from-a-fork/</a>)</div><div class=""><br class=""></div><div class="">Can somebody point me to more detailed documentation or tell me how should I proceed? Thanks!</div></div></div></blockquote><br class=""></div><div>(I don’t know what SR stands for… maybe “Service Request”? Anyway…)</div><div><br class=""></div><div>What I did was fork apple/swift so I have a copy of the project in my github account, and create branches off of that for whatever SR I’m working on. Then when the issue is resolved and I’ve committed all the changes to the branch hosted on <i class="">my</i> github, I go to Apple’s repository and submit a pull request to <i class="">their</i> master branch from whatever branch I was working on in my fork.</div><div><br class=""></div><div>I’m not sure this is the best way (in particular, I haven’t figured out how to automatically sync my fork’s master with Apple’s master), but it’s worked so far.</div><div><br class=""></div><div>I hope that helps! I’m pretty new to git/github as well, so I know where you’re coming from in terms of being confused by everything.</div><div><br class=""></div><div>- Dave Sweeris</div></body></html>