<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 19, 2017, at 4:59 PM, Greg Parker <<a href="mailto:gparker@apple.com" class="">gparker@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Michael, one of your changes broke all three ASAN bots. Please fix or revert ASAP.</div><div class=""><br class=""></div><div class="">(Could this be related to <a href="https://github.com/apple/swift/pull/8169" class="">https://github.com/apple/swift/pull/8169</a> ? I didn't confirm that the bot's change lists are correct.)</div></div></div></blockquote><div><br class=""></div><div>It is more complicated than you would think. I looked at this earlier. The change itself looks benign and in fact it was happening without ASAN when I had written it in a previous manner. I thought it was a compiler bug so I rewrote it in a simpler manner and the problem went away. If you look at 53eab13be8dd1202428af1b5c315f17c1ab02186, I am just moving some code into a method.</div><div><br class=""></div><div>It is not related to the other PR which is due to more COW copies occuring. It appears that I fixed all of the COW issues with a release stdlib (when client is compiled in Debug), but there may be additional COW copies when the stdlib is compiled in Debug mode. = /.</div><div><br class=""></div><div>Michael</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 18, 2017, at 11:48 AM, <a href="mailto:no-reply@swift.org" class="">no-reply@swift.org</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><h2 style="font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; width: 911px; background-color: red; color: white; text-align: center;" class=""></h2><h1 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">[<font class="FAILURE" style="color: red;">FAILURE</font>] oss-swift-incremental-ASAN-RA-osx [#212]</h1><table style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><th class="">Build URL:</th><td class=""><a href="https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/212/" style="color: rgb(0, 122, 255); text-decoration: none;" class="">https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/212/</a></td></tr><tr style="text-align: left;" class=""><th class="">Project:</th><td class="">oss-swift-incremental-ASAN-RA-osx</td></tr><tr style="text-align: left;" class=""><th class="">Date of build:</th><td class="">Sat, 18 Mar 2017 10:26:14 -0700</td></tr><tr style="text-align: left;" class=""><th class="">Build duration:</th><td class="">1 hr 22 min</td></tr></tbody></table><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Identified problems:</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><li class="">Assertion failure: This build failed because of an assertion failure. Below is a list of all errors in the build log:<ul class=""><li class=""><a href="https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/212/consoleFull#1684097467c38edd5a-00f9-40a2-abac-1db59f7a90ca" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Indication 1</a></li></ul></li></ul><br style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Changes</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">e52eea2199d8c23ceb82b6bbe85aeb341ccb0fa2</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">Michael Gottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] When a formal evaluation scope is in an inout conversion scope,</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/FormalEvaluation.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/FormalEvaluation.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">53eab13be8dd1202428af1b5c315f17c1ab02186</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">Michael Gottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Move foreignErrorPreparation code in ResultPlanBuilder into a</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/ResultPlan.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/ResultPlan.h</li></ul></li></ul></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></body></html>