<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks!<div class=""><br class=""></div><div class="">Michael</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 20, 2017, at 9:55 AM, Jordan Rose &lt;<a href="mailto:jordan_rose@apple.com" class="">jordan_rose@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="" applecontenteditable="true"><div class="">This bot has three separate issues:</div><div class=""><br class=""></div><div class="">- A flaky TSan test (that I thought <b class="">Kuba</b> disabled, but apparently not)</div><div class="">- A Foundation overlay test that <b class="">Philippe</b>&nbsp;knows about but&nbsp;hasn't gotten around to yet</div><div class="">- A SILGen failure that looks related to <b class="">Michael</b>'s work on SIL ownership</div><div class=""><br class=""></div><div class="">Michael, can you look into the last one if it's not fixed yet? This is&nbsp;SILGen/opaque_values_silgen.swift, specifically with a resilience-enabled build.</div><div class=""><br class=""></div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Feb 20, 2017, at 05:18, <a href="mailto:no-reply@swift.org" class="">no-reply@swift.org</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><h2 style="font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; width: 865px; background-color: red; color: white; text-align: center;" class="">New issue found!</h2><h2 style="font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; width: 865px; background-color: red; color: white; text-align: center;" class=""></h2><h1 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">[<font class="FAILURE" style="color: red;">FAILURE</font>] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#116]</h1><table style="font-family: 'Helvetica Neue', sans-serif; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><th class="">Build URL:</th><td class=""><a href="https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/" style="color: rgb(0, 122, 255); text-decoration: none;" class="">https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/</a></td></tr><tr style="text-align: left;" class=""><th class="">Project:</th><td class="">oss-swift_tools-RA_stdlib-RDA_test-macos-resilience</td></tr><tr style="text-align: left;" class=""><th class="">Date of build:</th><td class="">Mon, 20 Feb 2017 03:47:00 -0800</td></tr><tr style="text-align: left;" class=""><th class="">Build duration:</th><td class="">1 hr 31 min</td></tr></tbody></table><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Identified problems:</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><li class="">Assertion failure: This build failed because of an assertion failure. Below is a list of all errors in the build log:<ul class=""><li class=""><a href="https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#-1884046137c38edd5a-00f9-40a2-abac-1db59f7a90ca" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Indication 1</a></li></ul></li><li class="">Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:<ul class=""><li class=""><a href="https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#1358470745ee1a197b-acac-4b17-83cf-a53b95139a76" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Indication 1</a></li></ul></li><li class="">Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:<ul class=""><li class=""><a href="https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#1563699420fca400bf-2f4a-462e-b517-e058d770b2d7" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Indication 1</a></li></ul></li></ul><br style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Changes</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">70054ba09e83fceb684570902d513e8f0375d952</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">hughbellars:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Fix build, edit, build loop on Windows</p><ul class=""><li class="change-edit"><b class="">edit</b>: cmake/modules/SwiftSource.cmake</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">c6b32aea2c6166513fdd14dfbd79bba5d05a4eff</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Add APIs for creating managed buffers and managed rvalues in a</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenFunction.h</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenDecl.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">aa9efae56288e41a3686a340e4ec8cda84657a2b</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">jans.pavlovs:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Update map example code</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/core/Sequence.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">bdb4195de8c5f33c25d5d192bc69ca6fa1d7efb3</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] ManagedValue::{formalEvaluationBorrow,formalAccessBorrow}()</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenLValue.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">0ae6c2523882be544bb808b0d5a1f20df02e51c1</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Make SILGenBuilder::createCopyValue a drop in replacement for</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.h</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">6b05692d31a24fb1d1f19695e778412ea6775ab8</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Remove incorrect assumptions in</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">5717eeba673a3ad6be689d057ab4868fde2a1580</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Create a ManagedValue::formalAccessCopy(SILGenFunction &amp;,</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.h</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">9a964034960c2ec5cae78336813b63093f8bfe2a</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Refactor prepareArchetypeCallee to use a builder class instead</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenApply.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">53b777cf9c1cf1891c6134c2b67ea3e58e620394</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Add an assert that formalAccessCopy is only called in a</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">825765a0479379e2d7f842452370860954506d66</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Change createFormalAccessCopyAddr to take take/init parameters.</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/ManagedValue.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">5920daa373ce9e6ad9b1c63b2976b7f3491fd0f3</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Refactor getAddressForInPlaceInitialization onto SGFContext().</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenExpr.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenFunction.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">dd5120e9f0baeb1b0f16d8b867e0488aa99acc78</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Create a closure API called bufferForExprResult based on</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuiltin.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenLValue.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenApply.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenConvert.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">d4a5fe58beee33996e8cab2cace68b60d9ca780c</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">rudkx:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Attempt to bind the result of unwrapping optionals if we're asked to</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/Constraints/closures.swift</li><li class="change-edit"><b class="">edit</b>: lib/Sema/CSSolver.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">1e17d86836d2f8851d462d7397c638872b9581f3</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Change one instance of switch_enum{_addr} that were using</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/SILGen/implicitly_unwrapped_optional.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/optional.swift</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenConvert.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_bridging.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/vtable_thunks.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">a13289835e76fe5716fa780cbf6fa5722f044b4c</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">kyrtzidis:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[index] For extensions, relate the symbol reference that gets extended</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/Index/IndexSymbol.h</li><li class="change-edit"><b class="">edit</b>: test/Index/kinds.swift</li><li class="change-edit"><b class="">edit</b>: lib/Index/Index.cpp</li><li class="change-edit"><b class="">edit</b>: test/Index/roles.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">850e67434925022d48d565c4731f86c10116317d</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Change SILGenBuiltin emission of retain/release/autorelease to</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuiltin.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/builtins.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">3464a9399d21ceb6196f65664cc119462b1533dd</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">hughbellars:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Port SwiftLangSupport::resolvePathSymlinks to Windows</p><ul class=""><li class="change-edit"><b class="">edit</b>: tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">3d5f979dae6c3cfd0d9878770b15a3675b0bf22c</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Perform a borrow when the native inputs require a guaranteed</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/SILGen/foreign_errors.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_set_bridging.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_blocks_bridging.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_thunks.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/guaranteed_self.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_bridging.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_bridging_any.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_extensions.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_dictionary_bridging.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_properties.swift</li><li class="change-edit"><b class="">edit</b>: test/ClangImporter/optional.swift</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBridging.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_metatypes.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">4b1d99fcc31342cd1daa1ed33875850de5435a5b</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">kyrtzidis:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[index] Relate extension members with the extension symbol.</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/Index/roles.swift</li><li class="change-edit"><b class="">edit</b>: lib/Index/Index.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">4f23d61da03d6c9ab56a6216e98583a8c611b5d6</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">hughbellars:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Import print_function wherever we use print() in python code</p><ul class=""><li class="change-edit"><b class="">edit</b>: utils/coverage/coverage-touch-tests</li><li class="change-edit"><b class="">edit</b>: utils/bug_reducer/bug_reducer/opt_bug_reducer.py</li><li class="change-edit"><b class="">edit</b>: utils/rth</li><li class="change-edit"><b class="">edit</b>: utils/scale-test</li><li class="change-edit"><b class="">edit</b>: utils/bug_reducer/bug_reducer/func_bug_reducer.py</li><li class="change-edit"><b class="">edit</b>: utils/resolve-crashes.py</li><li class="change-edit"><b class="">edit</b>: utils/backtrace-check</li><li class="change-edit"><b class="">edit</b>: utils/swift_build_support/swift_build_support/diagnostics.py</li><li class="change-edit"><b class="">edit</b>: utils/bug_reducer/bug_reducer/swift_tools.py</li><li class="change-edit"><b class="">edit</b>: utils/bug_reducer/bug_reducer/random_bug_finder.py</li><li class="change-edit"><b class="">edit</b>: benchmark/scripts/compare_perf_tests.py</li><li class="change-edit"><b class="">edit</b>: benchmark/utils/convertToJSON.py</li><li class="change-edit"><b class="">edit</b>: utils/bug_reducer/bug_reducer/list_reducer.py</li><li class="change-edit"><b class="">edit</b>: benchmark/scripts/generate_harness/generate_harness.py</li><li class="change-edit"><b class="">edit</b>: benchmark/scripts/perf_test_driver/perf_test_driver.py</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">a5e7514197b7613b2626c5ee1fb43b6e02ec38b6</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">hughbellars:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Prefer the print function to the print statment in python code</p><ul class=""><li class="change-edit"><b class="">edit</b>: utils/scale-test</li><li class="change-edit"><b class="">edit</b>: utils/coverage/coverage-touch-tests</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">fe16cf869d65cd20fca7ce5666350b07e838bf91</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Sema: Move some code around for better organization</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckProtocol.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckGeneric.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">be50b2a624839deaf8184a5196cd7ef894673b3b</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Add new ownership APIs for enum extraction to SILGenBuilder.</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">b319a3aa322dd22b4a8a19b77edf71be0acd38d8</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Clean up some more duplication using the new GenericContext</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/AST/LazyResolver.h</li><li class="change-edit"><b class="">edit</b>: lib/AST/ASTContext.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/Decl.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/Serialization/ModuleFile.h</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/ASTContext.h</li><li class="change-edit"><b class="">edit</b>: lib/Serialization/Deserialization.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">880803aaba001d77bcaa28b8ce8b36149f0e96ad</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Initial plumbing for generic subscripts</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Serialization/Deserialization.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/Decl.h</li><li class="change-edit"><b class="">edit</b>: lib/ClangImporter/ImportDecl.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Parse/ParseDecl.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckDecl.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/DeclContext.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">cc54361b2a2832885adaea38fb5bcaf6e363a2a8</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Serialization: Add support for generic subscripts</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Serialization/Deserialization.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Serialization/Serialization.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/Serialization/ModuleFormat.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">26a266b15eb00c3f450c296adbd3d0eda1d2baa9</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mgottesman:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[silgen] Cleanup emitPreconditionOptionalHasValue and its uses so that</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.h</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenFunction.h</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenConvert.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_witnesses.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/vtable_thunks.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_bridging.swift</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenLValue.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/witnesses.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/expressions.swift</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/objc_ownership_conventions.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">1098e61ae1216b70d0508257b119b7126d568a15</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">hughbellars:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Fix debug info flags passed to MSVC/clang-cl</p><ul class=""><li class="change-edit"><b class="">edit</b>: cmake/modules/AddSwift.cmake</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">0da22a2e53249e5cf4e859d997635b72a5a012e0</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">hughbellars:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Fixup Windows specific compiler flags passed to MSVC/Clang-cl</p><ul class=""><li class="change-edit"><b class="">edit</b>: cmake/modules/AddSwift.cmake</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">9f9da4b6473e792ebbe465522a4b4b98d7aedc38</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">hughbellars:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[CMake] Simplify consecutive identical if statements</p><ul class=""><li class="change-edit"><b class="">edit</b>: cmake/modules/AddSwift.cmake</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">b60945fbd88a30686a3ad6530ad6139eb78ec73a</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">hughbellars:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[CMake] Use correct compiler flag for unoptimized MSVC/clang-cl builds</p><ul class=""><li class="change-edit"><b class="">edit</b>: cmake/modules/AddSwift.cmake</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">84de5392547dd8043c216acf137e5547c7c68d1b</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">practicalswift:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[swiftc (53 vs. 5456)] Add crasher in swift::ASTVisitor</p><ul class=""><li class="change-add"><b class="">add</b>: validation-test/compiler_crashers/28697-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">61b3b820f3947cafe041acc4cd1b54223a1fdf35</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">practicalswift:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[swiftc (54 vs. 5456)] Add crasher in</p><ul class=""><li class="change-add"><b class="">add</b>: validation-test/compiler_crashers/28698-isactuallycanonicalornull-forming-a-cantype-out-of-a-non-canonical-type.swift</li></ul></li></ul></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></body></html>