<div dir="ltr">PR'd: <a href="https://github.com/apple/swift/pull/7326">https://github.com/apple/swift/pull/7326</a><div><br></div><div>Although I would also ask: why is CaptureListExpr a <b>parent</b> of ClosureExpr and not a child?</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Jacob<br></div></div></div></div>
<br><div class="gmail_quote">On Tue, Feb 7, 2017 at 7:56 PM, Slava Pestov <span dir="ltr"><<a href="mailto:spestov@apple.com" target="_blank">spestov@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Feb 7, 2017, at 7:30 PM, Jacob Bandes-Storch via swift-dev <<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>> wrote:</div><br class="m_-1882571583119174456Apple-interchange-newline"><div><div dir="ltr">I just learned about CaptureListExpr when working on some diagnostics. Is there a particular reason that its member "closureBody" is an Expr* and not a ClosureExpr*? There seems to be <a href="https://github.com/apple/swift/blob/1e46f13184d7256c991b2ba9424af9efe3cd860f/lib/Parse/ParseExpr.cpp#L2425" target="_blank">only one place it's built</a>, and the body is always a ClosureExpr.<div><br></div><div>I can see <a href="https://github.com/apple/swift/blob/1e46f13184d7256c991b2ba9424af9efe3cd860f/lib/AST/ASTWalker.cpp#L663-L665" target="_blank">one minor place</a> where it might be less convenient to have a ClosureExpr, but otherwise there doesn't seem to be much of a reason to keep it generalized to Expr*.</div></div></div></blockquote><div><br></div></span>Since autoclosures cannot have capture lists, I think the change you’re suggesting makes sense.</div><div><br></div><div>Slava</div><div><br><blockquote type="cite"><div><div dir="ltr"><div><div><br clear="all"><div><div class="m_-1882571583119174456gmail_signature"><div dir="ltr"><div>Jacob<br></div></div></div></div>
</div></div></div>
______________________________<wbr>_________________<br>swift-dev mailing list<br><a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-dev" target="_blank">https://lists.swift.org/<wbr>mailman/listinfo/swift-dev</a><br></div></blockquote></div><br></div></blockquote></div><br></div></div>