<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Brian,<div class=""><br class=""></div><div class="">I know you sent this out 7 days ago, but thanks very much for doing this!</div><div class=""><br class=""></div><div class="">Ted</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 7, 2016, at 1:56 PM, Brian Gesiak via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hello all,<div class=""><br class=""></div><div class="">The latest LLVM Weekly <<a href="http://llvmweekly.org/issue/149" class="">http://llvmweekly.org/issue/149</a>> featured a blog post by some folks who make a static analyzer named PVS-Studio. They published a blog post <<a href="http://www.viva64.com/en/b/0446/" class="">http://www.viva64.com/en/b/0446/</a>> of the errors they encountered in the LLVM project. Although the report contained many false positives <<a href="https://twitter.com/chandlerc1024/status/794442485472706563" class="">https://twitter.com/chandlerc1024/status/794442485472706563</a>>, some did lead to code improvements.</div><div class=""><br class=""></div><div class="">I tried running the analyzer on the Swift codebase; here are the results: <a href="https://gist.github.com/modocache/00eb437ca3cac84960992cdc23fa0f52" class="">https://gist.github.com/modocache/00eb437ca3cac84960992cdc23fa0f52</a></div><div class=""><br class=""></div><div class="">It's a little hard to read, but there are some legitimate issues in the report. For example, line #709 in lib/IDE/TypeReconstruction.cpp returns 'false' for a method that has a return type of 'size_t', which is probably incorrect.</div><div class=""><br class=""></div><div class="">If you're interested in contributing to Swift, why not start by fixing some of these warnings? :)</div><div class=""><br class=""></div><div class="">- Brian Gesiak</div><div class=""><br class=""></div></div>
_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-dev<br class=""></div></blockquote></div><br class=""></div></body></html>