<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 9, 2016, at 17:30, Alexis via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Just stumbled across this mock NSDictionary implementation in the test suite:<br class=""><br class=""><a href="https://github.com/apple/swift/blob/a1dbe066adf826b27dd8e71234ba7e8ce2b26b73/validation-test/stdlib/Dictionary.swift#L1260-L1306" class="">https://github.com/apple/swift/blob/a1dbe066adf826b27dd8e71234ba7e8ce2b26b73/validation-test/stdlib/Dictionary.swift#L1260-L1306</a><div class=""><br class=""></div><div class="">It appears to be violating strict aliasing, but I’d just like to verify it with y’all since it’s a classic example of type punning that the average programmer expects to work, and will generally work in practice<span style="color: rgb(37, 37, 37); font-family: sans-serif; font-size: 14px; widows: 1; background-color: rgb(255, 255, 255);" class="">™</span>. Good learning opportunity!</div><div class=""><br class="">Notable lines:<br class=""><br class=""><br class=""><br class=""> struct Keys {<br class=""> var key0: AnyObject = TestObjCKeyTy(10)<br class=""> var key1: AnyObject = TestObjCKeyTy(20)<br class=""> var key2: AnyObject = TestObjCKeyTy(30)<br class=""> var key3: AnyObject = TestObjCKeyTy(40)<br class=""> }<div class=""><br class=""> var keys = [ Keys() ]<br class=""><br class=""><div class="">…</div><div class=""><br class=""></div><div class=""><div class=""> if theState.state == 0 {</div><div class=""> theState.state = 1</div><div class=""> theState.itemsPtr = AutoreleasingUnsafeMutablePointer(keys._baseAddressIfContiguous)</div><div class=""> theState.mutationsPtr = _fastEnumerationStorageMutationsPtr</div><div class=""> state.pointee = theState</div><div class=""> return 4</div><div class=""> }</div></div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">This appears to be casting a pointer to a struct Keys (containing 4 AnyObjects) to a pointer to AnyObject, declaring that it’s an array of 4 AnyObjects. So this is broken in three ways:</div><div class=""><br class=""></div><div class="">* Strict aliasing violation; just plain UB.</div><div class=""><br class=""></div><div class="">* There’s nothing that actually guarantees an instance of Keys is allocated inline like this, right? The compiler could decide it’s profitable for all instances of this type to be boxed. Or even random fields to be boxed?</div><div class=""><br class=""></div><div class="">* It could also choose to reorder the fields and insert padding however it pleases.</div></div></div></div></blockquote><br class=""></div><div>I agree with all three lines. Good catch. Can we get Andy’s Swift Type Sanitizer online? :-)</div><div><br class=""></div><div>Jordan</div><br class=""></body></html>