<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div><blockquote type="cite" class=""><div class="">On Oct 29, 2016, at 12:13 AM, Slava Pestov <<a href="mailto:spestov@apple.com" class="">spestov@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">It will become the default, but not yet, so yeah, you shouldn’t merge anything that only builds with this flag set.<div class=""><br class=""></div><div class="">Can you share the patch that adds private modifiers along with the linker errors you are seeing? Now would be a good time to sort out these issues.</div></div></div></blockquote><div><br class=""></div><div>I’m actually having trouble reproducing this now? I just rebased my branches onto master and using private/fileprivate on types, aliases, and functions seems to work perfectly fine (I tried a few things in Array and Dictionary). Did something interesting just get merged?</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Oct 28, 2016, at 4:16 PM, Alexis Beingessner <<a href="mailto:abeingessner@apple.com" class="">abeingessner@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="content-type" content="text/html; charset=utf-8" class=""><div dir="auto" class=""><div class="">Won't merging anything relying on this flag break the build? Is this going to become the "new" default soon?</div><div class=""><br class="">On Oct 28, 2016, at 6:43 PM, Slava Pestov <<a href="mailto:spestov@apple.com" class="">spestov@apple.com</a>> wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Oct 23, 2016, at 4:13 PM, Michael Gottesman via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class=""><blockquote type="cite" class="">On Oct 23, 2016, at 3:30 PM, Alexis Beingessner via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:<br class=""><br class="">Dave pointed out to me this week that the build crashes if the stdlib tries to use private/fileprivate. I tried it myself and lo and behold the linker can't find the private symbols. He couldn't recall what about the build caused that, though.<br class=""><br class="">Can anyone recall why this is? How hard is it to fix?<br class=""></blockquote><br class="">I am not 100% sure, but if it happens only with the stdlib and has to do with access control, I wouldn't be surprised if it has to do with -sil-serialize-all and friends. But I may be correct. I think Jordan is the right person to answer this question.<br class=""><br class="">What do you think Jordan?<br class="">Michael<br class=""></div></div></blockquote><div class=""><br class=""></div><div class="">Hi Alexis,</div><div class=""><br class=""></div>You can build the stdlib without sil-serialize-all now by passing a flag to build-script:</div><div class=""><br class=""></div><div class="">./utils/build-script — <span style="color: rgb(76, 47, 45); font-family: Menlo; background-color: rgb(223, 219, 196);" class="">--swift-stdlib-enable-resilience</span></div><div class=""><font color="#4c2f2d" face="Menlo" class=""><span style="background-color: rgb(223, 219, 196);" class=""><br class=""></span></font></div><div class=""><font color="#4c2f2d" face="Menlo" class=""><span style="background-color: rgb(223, 219, 196);" class="">Give that a shot and see if it fixes the issues you’re having with ‘private’.</span></font></div><div class=""><font color="#4c2f2d" face="Menlo" class=""><span style="background-color: rgb(223, 219, 196);" class=""><br class=""></span></font><blockquote type="cite" class=""><div class=""><div class=""><br class=""><blockquote type="cite" class="">_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class=""></blockquote><br class="">_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class=""></div></div></blockquote></div><br class=""></div></blockquote></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></body></html>