<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><div style="direction: inherit;">The graph only looks at deps from Foundation's tree because we have no generator for ninja to validate changes against. </div><br>Sent from my iPhone</div><div><br>On Sep 6, 2016, at 2:52 PM, Slava Pestov <<a href="mailto:spestov@apple.com">spestov@apple.com</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="Content-Type" content="text/html charset=utf-8">What do you do when the swift module file format changes? Should I bump the module version when something ABI-related changes, even if the serialization format itself didn’t change?<div class=""><br class=""></div><div class="">Slava</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 6, 2016, at 2:44 PM, Philippe Hausler <<a href="mailto:phausler@apple.com" class="">phausler@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Because Foundation has no information upon the dependency graph for swift; perhaps we should just be recompiling everything every single time for libFoundation.so. It seems like a waste of CPU cycles but I don’t really see any way around it. </div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Sep 6, 2016, at 2:41 PM, Slava Pestov via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">This error is caused by stale build artifacts:<div class=""><br class=""></div><div class="">/home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: symbol lookup error: /home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: undefined symbol: _TFesRxs22RandomAccessCollectionwx5Indexs10Strideablewx7IndiceszGVs14CountableRangewxS0__wx13IndexDistancezWxS2_11SubSequence7IndicesS4__wxS0_zWxS2_S5_S5_8Iterator7Element_WxS2_S6__zGS3_wxS0__WxS2_S7__zGVs16IndexingIteratorGS3_wxS0___WxS2_S5__zGS3_wxS0__WxS2_S4__zWxS2_S5_S6_S4__WxS2_S0__zWxS2_S5_S5_S7_S8__WxS2_8_Element_zWxS2_S5_S5_S7_S8__WxS0_6Stride_zWxS2_S5_S6_S4__WxS2_S6_S6__zGS3_wxS0__WxS2_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S5__zGS3_wxS0__WxS2_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_13IndexDistance_zWxS2_S5_S6_S4__WxS2_S5_S6__zGS3_wxS0__WxS2_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5__zGS3_wxS0__WxS2_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S6_S5__zGS3_wxS0__WxS2_S6_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7__zGS9_GS3_wxS0___WxS2_S6_S5_S5__zGS3_wxS0__WxS2_S6_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7__zGS9_GS3_wxS0___WxS2_S5_S6_S5__zGS3_wxS0__WxS2_S5_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5_S5__zGS3_wxS0__WxS2_S5_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7_S8__zWxS2_S5_S5_S7_S8__rS_g7indicesGS3_wxS0__</div><div class=""><br class=""></div><div class="">I changed the mangling and it appears something was not recompiled. Is anyone looking into these issues?</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Sep 6, 2016, at 2:06 PM, <a href="mailto:no-reply@swift.org" class="">no-reply@swift.org</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><h2 style="font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; width: 638px; background-color: red; color: white; text-align: center;" class=""></h2><h1 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">[<font class="FAILURE" style="color: red;">FAILURE</font>] oss-swift-incremental-RA-linux-ubuntu-14_04 [#7287]</h1><table style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><th class="">Build URL:</th><td class=""><a href="https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/7287/" style="color: rgb(0, 122, 255); text-decoration: none;" class="">https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/7287/</a></td></tr><tr style="text-align: left;" class=""><th class="">Project:</th><td class="">oss-swift-incremental-RA-linux-ubuntu-14_04</td></tr><tr style="text-align: left;" class=""><th class="">Date of build:</th><td class="">Tue, 06 Sep 2016 13:48:21 -0700</td></tr><tr style="text-align: left;" class=""><th class="">Build duration:</th><td class="">18 min</td></tr></tbody></table><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Tests:<span class="Apple-converted-space"> </span></h2><table width="100%" style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><td class="bg1" colspan="2"></td></tr><tr style="text-align: left;" class=""><td class="bg2" colspan="2">Name:<span class="Apple-converted-space"> </span><b class="">Swift(linux-x86_64)</b><br class="">Failed: 0 test(s), Passed: 8283 test(s), Total: 8283 test(s)</td></tr><tr style="text-align: left;" class=""><td class=""></td></tr><tr style="text-align: left;" class=""><td class="bg2" colspan="2">Name:<span class="Apple-converted-space"> </span><b class="">Swift-Unit</b><br class="">Failed: 0 test(s), Passed: 296 test(s), Total: 296 test(s)</td></tr><tr style="text-align: left;" class=""><td class=""></td></tr></tbody></table><br style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Changes</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">21ad46b3f650166fef63b458b799c70668c24134</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Replace ArchetypeBuilder's adoptArchetypes flag with generic</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckDecl.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/ArchetypeBuilder.h</li><li class="change-edit"><b class="">edit</b>: lib/AST/ArchetypeBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckGeneric.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeChecker.h</li><li class="change-edit"><b class="">edit</b>: lib/AST/ASTContext.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">fb347db4fab1fad6a2a78d8e661929c97949e240</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Add dump() method to Requirement and GenericEnvironment</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/ASTPrinter.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/Requirement.h</li><li class="change-edit"><b class="">edit</b>: lib/AST/ASTDumper.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/GenericEnvironment.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">247852cf6dd00a998a544bcf0b7e3ef67d929179</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Remove unused parameter from</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/AST/ProtocolConformance.h</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/Substitution.h</li><li class="change-edit"><b class="">edit</b>: lib/AST/ProtocolConformance.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/Substitution.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">798a07a937ff6bbda682ac776ad51df69464323b</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Fix Type::transform() building of GenericSignatures</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/Type.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">fbe95735980414dd4c256437a3069c305e41053d</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Add some utility methods to GenericSignature</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/GenericEnvironment.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/GenericSignature.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/Substitution.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/Module.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/Substitution.h</li><li class="change-edit"><b class="">edit</b>: lib/Sema/CSApply.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/GenericSignature.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">19c982bcd9994e1bcddf1db95ddfc6ba85ea1b85</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Add new TypeBase::getSuperclassForDecl()</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/Type.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/Types.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">c28529315bc75ccebf01ae45d00428e087c59a0c</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Tweak conformance lookup for class-constrained archetypes</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/Module.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">07790d3e5e79b292cdde7534c5804dd0cec34fd2</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">SILGen: Re-work witness thunk emission a bit</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenDecl.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGenPoly.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILGen/SILGen.h</li><li class="change-edit"><b class="">edit</b>: test/SILGen/witnesses.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">772cf3a2fa3a1fd2941895bf952997ac7acf5210</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">SIL Optimizer: More principled substitution remapping in devirtualizer</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/SILOptimizer/devirt_static_witness_method.sil</li><li class="change-edit"><b class="">edit</b>: lib/SILOptimizer/Utils/Devirtualize.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp</li><li class="change-edit"><b class="">edit</b>: lib/SIL/SILModule.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/SIL/SILModule.h</li><li class="change-edit"><b class="">edit</b>: lib/SILOptimizer/Transforms/SpeculativeDevirtualizer.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">890863da10938059c73dc7eda0f8b01ae785f806</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">ArchetypeBuilder: const correctness</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/swift/AST/ArchetypeBuilder.h</li><li class="change-edit"><b class="">edit</b>: include/swift/SIL/TypeLowering.h</li><li class="change-edit"><b class="">edit</b>: lib/AST/ArchetypeBuilder.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">71cf5919c6146849778ad454528f3f7d0d11ef86</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">ArchetypeBuilder: More principled usage of RequirementSource</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/ArchetypeBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: test/Generics/requirement_inference.swift</li><li class="change-edit"><b class="">edit</b>: test/Generics/superclass_constraint.swift</li><li class="change-edit"><b class="">edit</b>: test/Generics/associated_type_typo.swift</li><li class="change-edit"><b class="">edit</b>: lib/AST/GenericSignature.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/ArchetypeBuilder.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">f19192d498695e1f7f6c30eda36132bc32392b57</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">ArchetypeBuilder: Sort requirements in enumerateRequirements()</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/Generics/associated_type_typo.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/interface_type_mangling.swift</li><li class="change-edit"><b class="">edit</b>: lib/AST/GenericSignature.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/ArchetypeBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: test/Generics/requirement_inference.swift</li><li class="change-delete"><b class="">delete</b>: validation-test/IDE/crashers/073-swift-archetypebuilder-enumeraterequirements.swift</li><li class="change-add"><b class="">add</b>: validation-test/IDE/crashers_fixed/073-swift-archetypebuilder-enumeraterequirements.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">7a7af62012c14a85edb57d24597f6b51aea09f56</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">ArchetypeBuilder: use enumerateRequirements() in getGenericSignature()</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/Generics/superclass_constraint.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/witnesses.swift</li><li class="change-edit"><b class="">edit</b>: test/SILOptimizer/specialize_reabstraction.sil</li><li class="change-edit"><b class="">edit</b>: test/Serialization/serialize_attr.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/interface_type_mangling.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/specialize_attr.swift</li><li class="change-edit"><b class="">edit</b>: lib/AST/ArchetypeBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/GenericSignature.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/default_arguments_generic.swift</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/ArchetypeBuilder.h</li><li class="change-edit"><b class="">edit</b>: test/SIL/Parser/generic_signature_with_depth.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">9771ec84dd8c3fdc7188ec8c383ddb0c160b6b44</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Sema: Improve checking of associated type superclass constraints</p><ul class=""><li class="change-edit"><b class="">edit</b>: test/Generics/associated_types_inherit.swift</li><li class="change-edit"><b class="">edit</b>: test/decl/protocol/req/recursion.swift</li><li class="change-edit"><b class="">edit</b>: test/decl/protocol/conforms/associated_type.swift</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckProtocol.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/DiagnosticsSema.def</li><li class="change-edit"><b class="">edit</b>: test/NameBinding/reference-dependencies.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">15fd3da5dd3513c97d62d00104be5d6d48830427</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">SIL: Prepare parser for removal of getCanonicalManglingSignature()</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Parse/ParseSIL.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">3b1721795f5177f297c58ad21d73ad14a6f3c600</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Nuke GenericSignature::getCanonicalManglingSignature()</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/IRGen/GenProto.cpp</li><li class="change-edit"><b class="">edit</b>: test/SIL/Parser/generic_signature_with_depth.swift</li><li class="change-edit"><b class="">edit</b>: test/Serialization/function.swift</li><li class="change-edit"><b class="">edit</b>: test/Generics/superclass_constraint.swift</li><li class="change-edit"><b class="">edit</b>: test/SIL/Serialization/deserialize_generic_marker.sil</li><li class="change-edit"><b class="">edit</b>: lib/AST/ASTContext.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILGen/errors.swift</li><li class="change-edit"><b class="">edit</b>: test/SILGen/generic_literals.swift</li><li class="change-edit"><b class="">edit</b>: lib/AST/Mangle.cpp</li><li class="change-edit"><b class="">edit</b>: test/Generics/requirement_inference.swift</li><li class="change-edit"><b class="">edit</b>: lib/AST/ArchetypeBuilder.cpp</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckGeneric.cpp</li><li class="change-edit"><b class="">edit</b>: validation-test/stdlib/CollectionDiagnostics.swift</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/GenericSignature.h</li><li class="change-edit"><b class="">edit</b>: lib/AST/GenericSignature.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/ArchetypeBuilder.h</li><li class="change-edit"><b class="">edit</b>: test/SILGen/witness_same_type.swift</li><li class="change-edit"><b class="">edit</b>: test/SIL/Parser/default_witness_tables.sil</li><li class="change-edit"><b class="">edit</b>: lib/Sema/ConstraintSystem.cpp</li><li class="change-edit"><b class="">edit</b>: test/SILOptimizer/eager_specialize.sil</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/ASTContext.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">38e58b23aa9d4446d3726c840651adcaabbfda7e</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Fix regression with reference-dependencies-members test</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckProtocol.cpp</li><li class="change-edit"><b class="">edit</b>: include/swift/AST/Module.h</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">dc49f82c2a4ad10f71309ca822ddfb0e6027f6bb</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Sema: Eagerly mark associated type conformances as used</p><ul class=""><li class="change-add"><b class="">add</b>: test/SILOptimizer/Inputs/specialize_inherited_multifile.swift</li><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckProtocol.cpp</li><li class="change-add"><b class="">add</b>: test/SILOptimizer/specialize_inherited_multifile.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">db4464bf39b7102ff2889134a1f5e2f3ab0519a4</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Sema: Remove unused parameter from</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckProtocol.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">2149061df1ad4572e2519023498c644523fd2fd7</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Sema: Clean up hack forcing use of NSError-related conformances</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckProtocol.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">6e77f625852366913850f82a5e0e3dc905f49bff</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AST: Add some handy assertions to GenericSignature</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/GenericSignature.cpp</li><li class="change-edit"><b class="">edit</b>: lib/AST/ASTContext.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">af56a0108c1ed8b5adf88c99766067ea32df17c3</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Sema: Add a couple of comments</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/Sema/TypeCheckProtocol.cpp</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">0c30979f477ce8de146960b95a9c5583117f2220</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">spestov:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Resolve some crashers</p><ul class=""><li class="change-add"><b class="">add</b>: validation-test/compiler_crashers_fixed/28342-getpointerelementtype-is-not-storagetype.swift</li><li class="change-add"><b class="">add</b>: validation-test/compiler_crashers_fixed/28383-swift-constraints-constraintgraphnode-getmembertype.swift</li><li class="change-delete"><b class="">delete</b>: validation-test/compiler_crashers/28320-swift-archetypebuilder-enumeraterequirements.swift</li><li class="change-delete"><b class="">delete</b>: validation-test/compiler_crashers/28398-swift-archetypebuilder-getgenericsignature.swift</li><li class="change-add"><b class="">add</b>: validation-test/compiler_crashers_fixed/28398-swift-archetypebuilder-getgenericsignature.swift</li><li class="change-add"><b class="">add</b>: validation-test/compiler_crashers_fixed/28403-swift-genericsignature-getsubstitutionmap.swift</li><li class="change-add"><b class="">add</b>: validation-test/compiler_crashers_fixed/28320-swift-archetypebuilder-enumeraterequirements.swift</li><li class="change-delete"><b class="">delete</b>: validation-test/compiler_crashers/28399-getpointerelementtype-is-not-storagetype.swift</li><li class="change-add"><b class="">add</b>: validation-test/compiler_crashers_fixed/28399-getpointerelementtype-is-not-storagetype.swift</li><li class="change-delete"><b class="">delete</b>: validation-test/compiler_crashers/28403-swift-genericsignature-getsubstitutionmap.swift</li><li class="change-delete"><b class="">delete</b>: validation-test/compiler_crashers/28342-getpointerelementtype-is-not-storagetype.swift</li><li class="change-delete"><b class="">delete</b>: validation-test/compiler_crashers/28383-swift-constraints-constraintgraphnode-getmembertype.swift</li></ul></li></ul></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class=""></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></blockquote></body></html>