<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Why wasn't this caught by pull request testing?<div class=""><br class=""></div><div class="">Michael</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 31, 2016, at 3:56 PM, Philippe Hausler via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="content-type" content="text/html; charset=utf-8" class=""><div dir="auto" class=""><div class=""><div style="direction: inherit;" class="">Those tests have been disabled by <a href="https://github.com/apple/swift-corelibs-foundation/commit/b98f8d67071b0af39f85c589dfd6cb54ff7c06cd" class="">https://github.com/apple/swift-corelibs-foundation/commit/b98f8d67071b0af39f85c589dfd6cb54ff7c06cd</a></div><br class="">Sent from my iPhone</div><div class=""><br class="">On Aug 31, 2016, at 2:18 PM, Anders Bertelrud via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class="">Looks unrelated to the checkins mentioned in this email:<div class=""><br class=""></div><div class=""><div class=""><font face="Menlo" class="">Test Case 'TestNSHTTPURLResponse.test_MIMETypeAndCharacterEncoding_1' passed (0.0 seconds).</font></div><div class=""><font face="Menlo" class="">Test Case 'TestNSHTTPURLResponse.test_MIMETypeAndCharacterEncoding_2' started at 20:30:25.699</font></div><div class=""><font face="Menlo" class="">Test Case 'TestNSHTTPURLResponse.test_MIMETypeAndCharacterEncoding_2' passed (0.0 seconds).</font></div><div class=""><font face="Menlo" class="">Test Case 'TestNSHTTPURLResponse.test_MIMETypeAndCharacterEncoding_3' started at 20:30:25.699</font></div><div class=""><font face="Menlo" class="">Test Case 'TestNSHTTPURLResponse.test_MIMETypeAndCharacterEncoding_3' passed (0.0 seconds).</font></div><div class=""><font face="Menlo" class="">Test Suite 'TestNSHTTPURLResponse' passed at 20:30:25.699</font></div><div class=""><font face="Menlo" class=""><span class="Apple-tab-span" style="white-space:pre">        </span> Executed 25 tests, with 0 failures (0 unexpected) in 0.003 (0.003) seconds</font></div><div class=""><font face="Menlo" class="">Test Suite 'TestURLSession' started at 20:30:25.699</font></div><div class=""><font face="Menlo" class="">Test Case 'TestURLSession.test_dataTaskWithURL' started at 20:30:25.699</font></div><font face="Menlo" class=""><br class="Apple-interchange-newline"></font><div class=""><font face="Menlo" class="">Build timed out (after 45 minutes). Marking the build as failed.</font></div><font face="Menlo" class=""><br class="Apple-interchange-newline"></font><div class=""><font face="Menlo" class="">Build was aborted</font></div><br class=""><div class="">
<br class="Apple-interchange-newline"><span style="font-family: Helvetica; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Anders</span>
</div>
<br class=""><div class=""><blockquote type="cite" class=""><div class="">On 2016-08-31, at 14.15, <a href="mailto:no-reply@swift.org" class="">no-reply@swift.org</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><h2 style="font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; width: 702px; background-color: red; color: white; text-align: center;" class=""></h2><h1 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">[<font class="FAILURE" style="color: red;">FAILURE</font>] oss-swift-incremental-RA-linux-ubuntu-14_04 [#7230]</h1><table style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><th class="">Build URL:</th><td class=""><a href="https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/7230/" style="color: rgb(0, 122, 255); text-decoration: none;" class="">https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/7230/</a></td></tr><tr style="text-align: left;" class=""><th class="">Project:</th><td class="">oss-swift-incremental-RA-linux-ubuntu-14_04</td></tr><tr style="text-align: left;" class=""><th class="">Date of build:</th><td class="">Wed, 31 Aug 2016 13:03:22 -0700</td></tr><tr style="text-align: left;" class=""><th class="">Build duration:</th><td class="">1 hr 12 min</td></tr></tbody></table><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Identified problems:</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><li class="">Timeout: This build was marked as FAIL because it timed out.<ul class=""><li class=""><a href="https://ci.swift.org//job/oss-swift-incremental-RA-linux-ubuntu-14_04/7230/consoleFull#89513194756633f0f-8823-4f82-9a4a-0c0d97ce7760" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Indication 1</a></li></ul></li></ul><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Tests:<span class="Apple-converted-space"> </span></h2><table width="100%" style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><td class="bg1" colspan="2"></td></tr><tr style="text-align: left;" class=""><td class="bg2" colspan="2">Name:<span class="Apple-converted-space"> </span><b class="">Swift(linux-x86_64)</b><br class="">Failed: 0 test(s), Passed: 8279 test(s), Total: 8279 test(s)</td></tr><tr style="text-align: left;" class=""><td class=""></td></tr><tr style="text-align: left;" class=""><td class="bg2" colspan="2">Name:<span class="Apple-converted-space"> </span><b class="">Swift-Unit</b><br class="">Failed: 0 test(s), Passed: 230 test(s), Total: 230 test(s)</td></tr><tr style="text-align: left;" class=""><td class=""></td></tr></tbody></table><br style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Changes</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">3fa09465c42941444c336acd68092362facd87a1</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">nmaccharoli:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">[stdlib] Move empty check for string concatenation to front</p><ul class=""><li class="change-edit"><b class="">edit</b>: stdlib/public/core/String.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space"> </span><b class="">82b37b3e7fed122150dd602e29cae966cebf494d</b><span class="Apple-converted-space"> </span>by<span class="Apple-converted-space"> </span><b class="">anders:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Check for loose source files in the `Tests` directory (it's a package</p><ul class=""><li class="change-edit"><b class="">edit</b>: Sources/PackageLoading/PackageBuilder.swift</li><li class="change-edit"><b class="">edit</b>: Tests/PackageLoadingTests/ConventionTests.swift</li></ul></li></ul></div></blockquote></div><br class=""></div></div></blockquote><blockquote type="cite" class=""><div class=""><span class="">_______________________________________________</span><br class=""><span class="">swift-dev mailing list</span><br class=""><span class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a></span><br class=""><span class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a></span><br class=""></div></blockquote></div>_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-dev<br class=""></div></blockquote></div><br class=""></div></body></html>