<html><body><p>Thanks Jordan! I'll create a pull request.<br><br>Regards,<br><br>Vivian Kong<br>Software Developer<br>IBM Canada Toronto Lab<br><br><img width="16" height="16" src="cid:1__=8FBB0A98DFD000FE8f9e8a93df938690918c8FB@" border="0" alt="Inactive hide details for Jordan Rose ---2016/08/09 05:08:22 PM---Hi, Vivian. RuntimeStubs.h (along with the rest of SwiftShims"><font color="#424282">Jordan Rose ---2016/08/09 05:08:22 PM---Hi, Vivian. RuntimeStubs.h (along with the rest of SwiftShims) is a header that gets shipped with th</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Jordan Rose <jordan_rose@apple.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Vivian Kong/Toronto/IBM@IBMCA</font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">swift-dev <swift-dev@swift.org>, Robert Widmann <rwidmann@apple.com></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">2016/08/09 05:08 PM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [swift-dev] Build failure on s390x</font><br><font size="2" color="#5F5F5F">Sent by: </font><font size="2">jordan_rose@apple.com</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><font size="4">Hi, Vivian. RuntimeStubs.h (along with the rest of SwiftShims) is a header that gets shipped with the Swift library, so it can’t refer to anything outside of its folder. Since we don’t yet have a good way to annotate things as using the Swift calling convention in the SwiftShims headers, we should probably not be using the Swift calling convention there (at least for now). Can you write up a pull request removing the SWIFT_CC annotation from the functions declared in RuntimeStubs.h?</font><br><br><font size="4">(I’m a little concerned that Clang didn’t tell us that the calling convention isn’t consistent across declarations, but that’s a separate issue. Maybe the lack of an annotation isn’t strong enough information to produce a warning.)</font><br><br><font size="4">Thanks,</font><br><font size="4">Jordan</font><br><br>
<ul><ul><font size="4">On Aug 9, 2016, at 07:42, Vivian Kong via swift-dev <</font><a href="mailto:swift-dev@swift.org"><u><font size="4" color="#0000FF">swift-dev@swift.org</font></u></a><font size="4">> wrote:</font><br>
<p><font size="4">After apply this commit, the s390x build started to fail:</font><u><font size="4" color="#0000FF"><br></font></u><a href="https://github.com/apple/swift/commit/dc88e51321e0a4f281406c265a91308a06aa517f"><u><font size="4" color="#0000FF">https://github.com/apple/swift/commit/dc88e51321e0a4f281406c265a91308a06aa517f</font></u></a><font size="4"><br><br>The commit added 2 new functions in stdlib/public/SwiftShims/RuntimeStubs.h. They are used in stdlib/public/stubs/CommandLine.cpp with </font><b><font size="4">SWIFT_CC(swift)</font></b><font size="4"> macro. Since we use the LLVM's intrinsic "swiftcall" on s390x, this caused a build error. To fix it we added the </font><b><font size="4">SWIFT_CC(swift)</font></b><font size="4"> macro and </font><b><font size="4">#include "swift/Runtime/Config.h"</font></b><font size="4"> to RuntimeStubs.h. We then ran into this build error:<br></font><font size="4" face="Courier New"><br><module-includes>:9:10: note: in file included from <module-includes>:9:<br>#include "RuntimeStubs.h"<br>^<br>/localbox/vivkong/swift/build/Ninja-RelWithDebInfoAssert/swift-linux-s390x/./lib/swift/shims/RuntimeStubs.h:23:10: error: </font><b><font size="4" face="Courier New">'swift/Runtime/Config.h' file not found</font></b><font size="4" face="Courier New"><br>#include "swift/Runtime/Config.h"</font><font size="4"><br><br><br>I tried modifying stdlib/public/SwiftShims/CMakeLists.txt with<br></font><font size="4" face="Courier New"><br>include_directories(<br>${CMAKE_SOURCE_DIR}/include<br>)</font><font size="4"><br><br>But that didn't seem to work. Any suggestions on how to fix this?<br><br>Thanks for your help!<br><br>Regards,<br><br>Vivian Kong<br>Software Developer<br>IBM Canada Toronto Lab</font><p><font size="4">_______________________________________________<br>swift-dev mailing list</font><u><font size="4" color="#0000FF"><br></font></u><a href="mailto:swift-dev@swift.org"><u><font size="4" color="#0000FF">swift-dev@swift.org</font></u></a><font size="4"><br></font><font size="4"><a href="https://lists.swift.org/mailman/listinfo/swift-dev">https://lists.swift.org/mailman/listinfo/swift-dev</a></font></ul></ul><br><br><BR>
</body></html>