<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">It’s possible we’re not treating “macos” the same as “macosx”, and thus changing the way that methods with the same basename get imported. So it probably is that change.</div><div class=""><br class=""></div><div class="">…yep, it looks like we look for literal platform name strings in ClangImporter.cpp and ImportDecl.cpp.</div><div class=""><br class=""></div><div class="">Jordan</div><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 12, 2016, at 10:06, Manman &lt;<a href="mailto:mren@apple.com" class="">mren@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Not sure if this is related to my change of "AvailabilityAttr: we accept "macos" as the platform name.”. My change is a mechanic change of supporting both macosx and macos, and using “macOS” instead of “OS X” in diagnostics.<div class=""><br class=""></div><div class="">For example, this error message does not look related to my change:</div><div class=""><div class="">/Users/buildnode/jenkins/workspace/oss-swift-incremental-RA-osx/swift/test/ClangModules/AppKit_test.swift:8:17: error: unexpected error produced: method does not override any method from its superclass</div><br class="Apple-interchange-newline">&nbsp; override func read(from url: URL, ofType type: String) throws {</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Manman</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jul 11, 2016, at 7:08 PM, Mishal Shah &lt;<a href="mailto:mishal_shah@apple.com" class="">mishal_shah@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Master is currently broken due to following test failure. Can someone please look at these tests failures?<div class=""><br class=""></div><div class=""><pre class="console-output" style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; font-size: 13px; background-color: rgb(43, 48, 59); color: rgb(192, 197, 206); padding: 20px; border-top-left-radius: 3px; border-top-right-radius: 3px; border-bottom-right-radius: 3px; border-bottom-left-radius: 3px;">Failing Tests (13):
    Swift :: ClangModules/AppKit_test.swift
    Swift :: ClangModules/availability_app_extension.swift
    Swift :: ClangModules/availability_implicit_macosx.swift
    Swift :: ClangModules/availability_macosx.swift
    Swift :: ClangModules/enum-with-target.swift
    Swift :: ClangModules/objc_factory_method.swift
    Swift :: ClangModules/objc_init.swift
    Swift :: IDE/print_clang_framework.swift
    Swift :: Sema/availability_versions_objc_api.swift
    Swift :: Sema/deprecation_osx.swift
    Swift :: SourceKit/CursorInfo/cursor_info.swift
    Swift :: SourceKit/DocSupport/doc_clang_module.swift
    Swift :: SourceKit/InterfaceGen/gen_clang_module.swift

  Expected Passes    : 8248
  Expected Failures  : 10
  Unsupported Tests  : 91
  Unexpected Failures: 13</pre><div class=""><br class=""></div></div><div class="">Thanks,</div><div class="">Mishal Shah<br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jul 11, 2016, at 7:51 PM, <a href="mailto:no-reply@swift.org" class="">no-reply@swift.org</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><h2 style="font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; width: 848px; background-color: red; color: white; text-align: center;" class=""></h2><h1 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">[<font class="FAILURE" style="color: red;">FAILURE</font>] oss-swift-incremental-RA-osx [#5124]</h1><table style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><th class="">Build URL:</th><td class=""><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/" style="color: rgb(0, 122, 255); text-decoration: none;" class="">https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/</a></td></tr><tr style="text-align: left;" class=""><th class="">Project:</th><td class="">oss-swift-incremental-RA-osx</td></tr><tr style="text-align: left;" class=""><th class="">Date of build:</th><td class="">Mon, 11 Jul 2016 16:25:55 -0700</td></tr><tr style="text-align: left;" class=""><th class="">Build duration:</th><td class="">25 min</td></tr></tbody></table><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Identified problems:</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><li class="">Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:<ul class=""><li class=""><a href="https://ci.swift.org//job/oss-swift-incremental-RA-osx/5124/consoleFull#1869590583ee1a197b-acac-4b17-83cf-a53b95139a76" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Indication 1</a></li></ul></li><li class="">Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:<ul class=""><li class=""><a href="https://ci.swift.org//job/oss-swift-incremental-RA-osx/5124/consoleFull#-943443896fca400bf-2f4a-462e-b517-e058d770b2d7" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Indication 1</a></li></ul></li></ul><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Tests:<span class="Apple-converted-space">&nbsp;</span></h2><table width="100%" style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><tbody class=""><tr style="text-align: left;" class=""><td class="bg1" colspan="2"></td></tr><tr style="text-align: left;" class=""><td class="bg2" colspan="2">Name:<span class="Apple-converted-space">&nbsp;</span><b class="">Swift</b><br class="">Failed: 13 test(s), Passed: 8080 test(s), Total: 8093 test(s)</td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/ClangModules/AppKit_test_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.ClangModules.AppKit_test.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/ClangModules/availability_app_extension_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.ClangModules.availability_app_extension.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/ClangModules/availability_implicit_macosx_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.ClangModules.availability_implicit_macosx.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/ClangModules/availability_macosx_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.ClangModules.availability_macosx.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/ClangModules/enum_with_target_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.ClangModules.enum-with-target.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/ClangModules/objc_factory_method_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.ClangModules.objc_factory_method.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/ClangModules/objc_init_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.ClangModules.objc_init.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/IDE/print_clang_framework_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.IDE.print_clang_framework.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/Sema/availability_versions_objc_api_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.Sema.availability_versions_objc_api.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/Sema/deprecation_osx_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.Sema.deprecation_osx.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/SourceKit_CursorInfo/cursor_info_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.SourceKit/CursorInfo.cursor_info.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/SourceKit_DocSupport/doc_clang_module_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.SourceKit/DocSupport.doc_clang_module.swift</a></li></ul></b></td></tr><tr bgcolor="white" style="text-align: left;" class=""><td class="test_failed" colspan="2"><b class=""><ul class=""><li class="">Failed:<span class="Apple-converted-space">&nbsp;</span><a href="https://ci.swift.org/job/oss-swift-incremental-RA-osx/5124/testReport/junit/Swift/SourceKit_InterfaceGen/gen_clang_module_swift" style="color: rgb(0, 122, 255); text-decoration: none;" class="">Swift.SourceKit/InterfaceGen.gen_clang_module.swift</a></li></ul></b></td></tr><tr style="text-align: left;" class=""><td class=""></td></tr><tr style="text-align: left;" class=""><td class="bg2" colspan="2">Name:<span class="Apple-converted-space">&nbsp;</span><b class="">Swift-Unit</b><br class="">Failed: 0 test(s), Passed: 269 test(s), Total: 269 test(s)</td></tr><tr style="text-align: left;" class=""><td class=""></td></tr></tbody></table><br style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><h2 style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Changes</h2><ul style="color: rgb(57, 57, 57); font-family: 'Helvetica Neue', sans-serif; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 300; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">2d798a374970e61df4076236887e00a4e6de50c1</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mren:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AvailabilityAttr: we accept "macos" as the platform name.</p><ul class=""><li class="change-edit"><b class="">edit</b>: lib/AST/Decl.cpp</li><li class="change-edit"><b class="">edit</b>: test/SemaObjC/property-noninherited-availability-attr.m</li><li class="change-edit"><b class="">edit</b>: lib/Basic/Targets.cpp</li><li class="change-edit"><b class="">edit</b>: test/SemaObjC/attr-deprecated.m</li><li class="change-edit"><b class="">edit</b>: lib/Parse/ParseDecl.cpp</li><li class="change-edit"><b class="">edit</b>: include/clang-c/Index.h</li><li class="change-edit"><b class="">edit</b>: test/SemaObjC/attr-availability-1.m</li><li class="change-edit"><b class="">edit</b>: test/SemaObjC/attr-availability.m</li><li class="change-edit"><b class="">edit</b>: test/Sema/attr-availability-macosx.c</li><li class="change-edit"><b class="">edit</b>: test/Sema/attr-availability.c</li><li class="change-edit"><b class="">edit</b>: test/Index/annotate-comments-availability-attrs.cpp</li><li class="change-edit"><b class="">edit</b>: test/SemaCXX/attr-deprecated-replacement-fixit.cpp</li><li class="change-edit"><b class="">edit</b>: include/clang/Basic/Attr.td</li><li class="change-edit"><b class="">edit</b>: include/clang/Basic/DiagnosticParseKinds.td</li><li class="change-edit"><b class="">edit</b>: test/Misc/ast-print-objectivec.m</li><li class="change-edit"><b class="">edit</b>: include/clang/Basic/AttrDocs.td</li><li class="change-edit"><b class="">edit</b>: test/Index/availability.c</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">aa31d6532a151cf91a4f6968abd51f4444ed38e4</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">mren:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">AvailabilityAttr: update the document for macosx</p><ul class=""><li class="change-edit"><b class="">edit</b>: include/clang/Basic/AttrDocs.td</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">fbc4dd3ac8c2400e7f942cfb7325f963660e3455</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">renzo.crisostomo:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Create blue folder references for root directories</p><ul class=""><li class="change-edit"><b class="">edit</b>: Sources/Xcodeproj/pbxproj().swift</li><li class="change-edit"><b class="">edit</b>: Sources/Xcodeproj/generate().swift</li><li class="change-edit"><b class="">edit</b>: Sources/Commands/SwiftPackageTool.swift</li><li class="change-edit"><b class="">edit</b>: Tests/Xcodeproj/GenerateXcodeprojTests.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">cd97385117783debb7f704558cbfc48ba950f001</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">renzo.crisostomo:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Move findDirectoryReferences to Xcodeproj module</p><ul class=""><li class="change-edit"><b class="">edit</b>: Sources/Xcodeproj/pbxproj().swift</li><li class="change-edit"><b class="">edit</b>: Sources/Xcodeproj/generate().swift</li><li class="change-edit"><b class="">edit</b>: Sources/Commands/SwiftPackageTool.swift</li><li class="change-edit"><b class="">edit</b>: Tests/Xcodeproj/GenerateXcodeprojTests.swift</li></ul></li><br class=""><li class="">Commit<span class="Apple-converted-space">&nbsp;</span><b class="">b295acb9672b76d31cbd80cbecedef0dde3410c3</b><span class="Apple-converted-space">&nbsp;</span>by<span class="Apple-converted-space">&nbsp;</span><b class="">jordan_rose:</b><p class="commit-message" style="font-family: Menlo, fixed; white-space: pre-wrap;">Update for SE-0025 ('private' and 'fileprivate')</p><ul class=""><li class="change-edit"><b class="">edit</b>: Sources/PackageLoading/PackageExtensions.swift</li><li class="change-edit"><b class="">edit</b>: Sources/SourceControl/CheckoutManager.swift</li><li class="change-edit"><b class="">edit</b>: Sources/Get/Package.swift</li><li class="change-edit"><b class="">edit</b>: Sources/Utility/Path.swift</li><li class="change-edit"><b class="">edit</b>: Sources/Basic/OrderedSet.swift</li><li class="change-edit"><b class="">edit</b>: Sources/Utility/walk.swift</li><li class="change-edit"><b class="">edit</b>: Fixtures/DependencyResolution/External/Complex/deck-of-playing-cards/src/Deck.swift</li><li class="change-edit"><b class="">edit</b>: Sources/Basic/TOML.swift</li><li class="change-edit"><b class="">edit</b>: Tests/Get/VersionGraphTests.swift</li><li class="change-edit"><b class="">edit</b>: Fixtures/DependencyResolution/External/IgnoreIndirectTests/deck-of-playing-cards/src/Deck.swift</li><li class="change-edit"><b class="">edit</b>: Sources/PackageLoading/Manifest+parse.swift</li><li class="change-edit"><b class="">edit</b>: Tests/Functional/ClangModuleTests.swift</li><li class="change-edit"><b class="">edit</b>: Sources/Basic/ByteString.swift</li><li class="change-edit"><b class="">edit</b>: Sources/Basic/Path.swift</li><li class="change-edit"><b class="">edit</b>: Sources/Get/PackagesDirectory.swift</li><li class="change-edit"><b class="">edit</b>: Sources/PackageLoading/Module+PkgConfig.swift</li><li class="change-edit"><b class="">edit</b>: Tests/PackageLoading/ModuleDependencyTests.swift</li></ul></li></ul></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></body></html>