<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Hm. That might be a nice balance, and it’s not entirely a lie: that’s the version of the <i class="">compiler</i> that you’re using, if not the stdlib and runtime. I’d still like to put it behind a flag, so that we can turn it off it certain configurations, like <a href="https://github.com/apple/swift/pull/2105" class="">#2105</a> attempted to do.</div><div class=""><br class=""></div><div class="">Dmitri, any comments, since you caught the issue last time?</div><div class=""><br class=""></div><div class="">Jordan</div><div class=""><br class=""></div><br class=""><div><blockquote type="cite" class=""><div class="">On May 5, 2016, at 21:12, rintaro ishizaki <<a href="mailto:fs.output@gmail.com" class="">fs.output@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Sorry, accidentally clicked send button..<div class=""><br class=""></div>I've wrote PoC code here:<div class=""><a href="https://github.com/rintaro/swift/commit/9bf18d46f4933ace03948417087bade084104edb" class="">https://github.com/rintaro/swift/commit/9bf18d46f4933ace03948417087bade084104edb</a><br class=""></div><div class=""><br class=""></div><div class="">Of course, this changes the semantics of `--version` output.</div><div class="">So I'm not sure we can accept this or not.</div><div class="">Any thought?</div><div class=""><br class=""></div><div class="">Rintaro</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">2016-05-06 13:08 GMT+09:00 rintaro ishizaki <span dir="ltr" class=""><<a href="mailto:fs.output@gmail.com" target="_blank" class="">fs.output@gmail.com</a>></span>:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="">Hi all,</div><div class=""><br class=""><font face="monospace, monospace" class="">getSwiftFullVersion</font> output must take account stdlib revsion?<br class=""></div><div class=""><br class=""></div>How about get the revision hash from the Swift repository<div class="">*excluding* stdlib/, test/ and validation-test/ directories.</div><div class=""><br class=""><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px" class=""><div class=""><font face="monospace, monospace" class="">git log -1 --pretty=format:%H -- \</font></div><div class=""><div class=""><font face="monospace, monospace" class=""> . \</font></div><div class=""><font face="monospace, monospace" class=""> :(exclude)stdlib \</font></div><div class=""><font face="monospace, monospace" class=""> :(exclude)test \</font></div><div class=""><font face="monospace, monospace" class=""> :(exclude)validation-test</font></div></div></blockquote><div class=""><br class=""></div><div class="">Instead of,</div><br class=""><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px" class=""><font face="monospace, monospace" class="">git log -1 --pretty=format:%H</font></blockquote><div class=""><br class=""></div><div class="">Or more specifically, just include only "compiler" related directories:</div><div class=""><br class=""></div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px" class=""><font face="monospace, monospace" class="">git log -1 --pretty=format:%H -- include/ lib/ tools/</font></blockquote><div class=""><br class=""></div><div class=""><p class="">I've wrote PoC code</p></div></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote"><div class=""><div class="h5">2016-04-12 2:22 GMT+09:00 Jordan Rose via swift-dev <span dir="ltr" class=""><<a href="mailto:swift-dev@swift.org" target="_blank" class="">swift-dev@swift.org</a>></span>:<br class=""></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><div class="h5"><div style="word-wrap:break-word" class=""><span class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Apr 7, 2016, at 14:01, Chris Lattner <<a href="mailto:clattner@apple.com" target="_blank" class="">clattner@apple.com</a>> wrote:</div><br class=""><div class=""><div class=""><br class=""><blockquote type="cite" class="">On Apr 6, 2016, at 11:08 AM, Jordan Rose via swift-dev <<a href="mailto:swift-dev@swift.org" target="_blank" class="">swift-dev@swift.org</a>> wrote:<br class=""><br class="">I imagine it's because your git hash has changed, which is used in the --version output for swiftc. I'm not sure how to avoid that cost entirely, but we could add a CMake option to not do it (which you could set locally), and we could probably move it to a library that isn't used by most of those tools (so that we're only re-linking swiftc).<br class=""></blockquote><br class="">Could we move the hash to be a text file stored next to the executables in the installdir? That way the text file gets updated, but not the binaries?</div></div></blockquote><br class=""></div></span><div class="">Oh, that's clever. Maybe that's good enough for local builds. I'd want to be careful about it for the binary we ship (to not waste an fstat).</div><div class=""><br class=""></div><div class="">FWIW this isn't <i class="">quite</i> just --version output; we also stamp it into swiftmodule files. But any build with an actual submission tag will use that instead.</div><div class=""><br class=""></div><div class="">Jordan</div><br class=""></div><br class=""></div></div><span class="">_______________________________________________<br class="">
swift-dev mailing list<br class="">
<a href="mailto:swift-dev@swift.org" target="_blank" class="">swift-dev@swift.org</a><br class="">
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class="">
<br class=""></span></blockquote></div><br class=""></div>
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>