<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Should just be fine, though it'll necessitate source changes in Builtins.cpp.</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature">-- Harlan<br></div><div><br>On Mar 11, 2016, at 5:31 PM, Ben Langmuir via swift-dev <<a href="mailto:swift-dev@swift.org">swift-dev@swift.org</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="Content-Type" content="text/html charset=utf-8"><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 11, 2016, at 5:21 PM, Harlan Haskins via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hey all,<div class=""><br class=""></div><div class="">There were some huge improvements in LLVM’s intrinsics lookup that dramatically reduce object file size and compile time.</div><div class=""><br class=""></div><div class="">Specifically, <font face="Menlo" class="">llvm/IR/Intrinsics.h</font> gained <span style="font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; white-space: pre; background-color: rgb(255, 255, 255);" class="">lookupLLVMIntrinsicByName</span><span style="white-space: pre; background-color: rgb(255, 255, 255);" class="">, which replaces</span> 44k lines of tablegen’d code in <font face="Menlo" class="">llvm/IR/Intrinsics.gen</font> with a binary search. It seems to have reduced object size by 400KB and compile time by about 35s. We include <font face="Menlo" class="">Intrinsics.gen</font> in <font face="Menlo" class="">lib/AST/Builtins.cpp</font>.</div><div class=""><br class=""></div><div class="">We should look into cherry-picking those changes into <font face="Menlo" class="">apple/swift-llvm</font> to see if we can benefit from those compile time and size improvements.</div><div class=""><br class=""></div><div class="">The relevant SVN revisions are r258757, r258774, r258871, r258875, and r258897.</div></div></div></blockquote><div><br class=""></div><div>Can we just wait until stable is merged forward (+Michael G who has been handling these merges)? That will pick these up “for free” rather than trying to cherry-pick them out of order.</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">— Harlan</div></div>_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class=""></div></blockquote></div><br class=""></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>swift-dev mailing list</span><br><span><a href="mailto:swift-dev@swift.org">swift-dev@swift.org</a></span><br><span><a href="https://lists.swift.org/mailman/listinfo/swift-dev">https://lists.swift.org/mailman/listinfo/swift-dev</a></span><br></div></blockquote></body></html>