<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Doug,<div class=""><br class=""></div><div class="">These changes don’t cherry-pick cleanly to swift-2.2-branch.</div><div class=""><br class=""></div><div class="">Please create a pull request for swift-2.2-branch that cherry-picks in these changes and resolves the merge conflicts.</div><div class=""><br class=""></div><div class="">Otherwise, <b class="">Approved</b>&nbsp;for Swift 2.2.</div><div class=""><br class=""></div><div class="">Ted</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 2, 2016, at 4:39 PM, Douglas Gregor &lt;<a href="mailto:dgregor@apple.com" class="">dgregor@apple.com</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi Ted,<br class=""><br class="">The #selector expression has both a discoverability and a usability problem due to fairly poor code completion. These two changes:<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre">        </span><a href="https://github.com/apple/swift/commit/9736d54a771e87cc37be5c040404f6e387f766ec" class="">https://github.com/apple/swift/commit/9736d54a771e87cc37be5c040404f6e387f766ec</a><br class=""><span class="Apple-tab-span" style="white-space:pre">        </span>https://github.com/apple/swift/commit/f5cb1151c1ba4d8e40705ff31cb17c74c97daa4a<br class=""><br class="">introduce much better code completion for #selector. The first commit makes<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre">        </span>#selector(&lt;#@objc method#&gt;)<br class=""><br class="">an expression-specific (i.e., very high priority) completion when code-completing an argument for a parameter of type “ObjectiveC.Selector”, e.g.,<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre">        </span>obj.performSelector(&lt;complete here and get #selector(&lt;#@objc method#&gt;)&gt;<br class=""><br class="">while the second provides compound-name completions for method references within a #selector subexpression, e.g.,<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre">        </span>#selector(NSObject.&lt;complete here&gt;<br class=""><br class="">will give completions like<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre">        </span>performSelector(_:withObject:)<br class=""><br class="">and<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre">        </span>init<br class=""><br class="">and so on.<br class=""><br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre">        </span>- Doug<br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>