<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">I feel that the SILParser crasher one is too open ended for a specific bug report. But I would suggest looking into those as well. Here are some more concrete things:</div><div class=""><br class=""></div><div class=""><a href="https://bugs.swift.org/browse/SR-339" class="">https://bugs.swift.org/browse/SR-339</a></div><div class=""><a href="https://bugs.swift.org/browse/SR-340" class="">https://bugs.swift.org/browse/SR-340</a></div><div class=""><a href="https://bugs.swift.org/browse/SR-341" class="">https://bugs.swift.org/browse/SR-341</a></div><div class=""><a href="https://bugs.swift.org/browse/SR-342" class="">https://bugs.swift.org/browse/SR-342</a></div><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 22, 2015, at 1:48 PM, Michael Gottesman via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">You know what, let me file some bugs. I just thought of some more.<br class=""><div class=""><br class=""></div><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Dec 22, 2015, at 1:45 PM, Michael Gottesman via swift-dev <<a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Here are some off the top of my head. Many are related to code quality. Tell me what you think:<div class=""><br class=""></div><div class="">1. We have recently gotten some SILParser crashers. These need to be fixed. I looked at 1-2 of them and the ones I looked at are where we should be giving out a diagnostic but are instead just asserting.</div><div class=""><br class=""></div><div class="">2. The SILParser is a recursive descent parser. In general when one implements a recursive descent parser, one should above the routine that does the various parts of the parsing show the grammar being parsed. SILParser has inconsistently done this. I would go through all of the methods and see which are missing this documentation and fix the documentation.</div><div class=""><br class=""></div><div class="">3. parseSILInstruction is horrible and makes me cry every time I see it. It is a method that is ~1900 lines with a huge switch in it. We should refactor it into a visitor structure. In fact it is large enough that we should consider moving it into its own file if it is possible.</div><div class=""><br class=""></div><div class="">Michael</div><div class=""><br class=""></div><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Dec 22, 2015, at 12:02 PM, Davide Italiano <<a href="mailto:dccitaliano@gmail.com" class="">dccitaliano@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sun, Dec 13, 2015 at 4:29 PM, Michael Gottesman via swift-dev <span dir="ltr" class=""><<a href="mailto:swift-dev@swift.org" target="_blank" class="">swift-dev@swift.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word" class="">This is a small starter project for those who are interested in working with SIL.<div class=""><br class=""></div><div class="">The SIL Parser currently is unable to parse switch_enum of undef. I wrote a patch that does the work some time ago, but I never have had time to finish it (i.e. make sure everything works ok/write tests). I posted the patch in this issue:</div><div class=""><br class=""></div><div class=""><a href="https://bugs.swift.org/browse/SR-210" target="_blank" class="">https://bugs.swift.org/browse/SR-210</a></div><div class=""><br class=""></div><div class="">My hope is that even though a lot of the work is already done this may serve as good starting point for someone who wants to poke at the SIL Parser (a part of the code base that has not gotten as much attention as others).</div><div class=""><br class=""></div><div class="">Michael</div>
<img src="https://u2002410.ct.sendgrid.net/wf/open?upn=79XlU13HKQuyazZd2eRLaYvtMkUtsFa7a8eJlCvd9o2s25jsmd5T4WQVEpbx7Czbc8Ox4vrD4TXO0Z7uK-2B5kJY7qngw6zI3TrAkybmS9HxZNqCTCeGFnEeG5Dd9jPxaQVjAwNL5b8zBLmx4Y06f5fC5kCC-2BR6FLcCW7GWp1FBvzhjAJ82dNAoQcGv259Tn7wB6J6ngSPYTt3KSVA5yCcbPmgHZvEtKycjeXMvwJf4oM-3D" alt="" style="min-height: 1px ! important; width: 1px ! important; border-width: 0px ! important; margin: 0px ! important; padding: 0px ! important;" border="0" height="1" width="1" class="">
</div><br class=""></blockquote><div class=""><div class="">Hi Michael,<br class=""></div><div class="">I'm interested in something like this. I
noticed this project has been already taken, but you mentioned in a
subsequent mail you have a list of them. What are the other proposals?<br class=""><br class=""></div><div class="">Thank you,<br class=""><br class="">--<br class=""></div>Davide<br class=""></div></div></div></div>
</div></blockquote></div><br class=""></div>
<img src="https://u2002410.ct.sendgrid.net/wf/open?upn=BsPB5S3Z2usbY-2FzcCsd-2F2r4MihYe9FiKHjzH65yItK7J6rS4DoTbM4jv0vS1bC3hWbWYBW6cWzh5v94gWjKZn6b0nKBw2YjCKRT-2BwZT6iQ1SXH2b3PCyVrNdtPRlSjuyXOc-2FdwMNOBrHuyVZCFN66ALRzrP-2FN8iKxzEjCSMGRbi8-2FF8vG7HA7012epGEPmkhL88nu4y04Sk67LBrTe3BHNDhmgT4TiBJmRUnbjiqzP8-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;" class="">
</div>
_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class=""><a href="https://lists.swift.org/mailman/listinfo/swift-dev" class="">https://lists.swift.org/mailman/listinfo/swift-dev</a><br class=""></div></blockquote></div><br class=""></div>
<img src="https://u2002410.ct.sendgrid.net/wf/open?upn=BsPB5S3Z2usbY-2FzcCsd-2F2r4MihYe9FiKHjzH65yItK7bDn6yrqmosozAVYD6513x8GApuMry9FFeTyBgBXoqUczx0XJFqzsHpoXcjuoPJcKGdwlot4l4MWxuxrJ5hD1qk8bOvI5X1CoczNsY8KTlXDgZL2V5dOoh2RzmD0rkTp7xZ5Qaz-2Fw73TK2JwdSlPEXrX29gAVpT2-2B4SrYNjhAkoZNx-2BXHcWPK5S02iCZUVsV0-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;" class="">
</div>
_______________________________________________<br class="">swift-dev mailing list<br class=""><a href="mailto:swift-dev@swift.org" class="">swift-dev@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-dev<br class=""></div></blockquote></div><br class=""></body></html>