<div dir="ltr">Okay, that works.<div><br></div><div>I have a few questions about SR-210:<div><br></div><div>1) The attached patch adds support for undefined integer value-cases in the switch_value instruction. What is the runtime meaning of this construct?</div><div><br></div><div>2) Are there any other SIL instructions in the select/switch family that need modifications? If yes, which? At least some of them (e.g. select_value) don't support this either.</div><div><br></div><div>3) Are there any areas that need special attention when writing tests and otherwise validating this change?</div><div><br></div><div><br></div><div>--Emanuel</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 16, 2015 at 10:15 AM, Michael Gottesman <span dir="ltr"><<a href="mailto:mgottesman@apple.com" target="_blank">mgottesman@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">SGTM. If you want as you finish these, I have a list of them = ).<div><br></div><div>I just filed another one:</div><div><br></div><div><a href="https://bugs.swift.org/browse/SR-247" target="_blank">https://bugs.swift.org/browse/SR-247</a></div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Michael</div></font></span><div><div class="h5"><div><br><div><blockquote type="cite"><div>On Dec 16, 2015, at 5:30 AM, Emanuel Zephir <<a href="mailto:emanuelzephir@gmail.com" target="_blank">emanuelzephir@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Unless anyone objects, I'd like to claim this. I've assigned issue SR-210 to myself.<div><br></div><div>--Emanuel</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Dec 13, 2015 at 1:29 PM, Michael Gottesman via swift-dev <span dir="ltr"><<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">This is a small starter project for those who are interested in working with SIL.<div><br></div><div>The SIL Parser currently is unable to parse switch_enum of undef. I wrote a patch that does the work some time ago, but I never have had time to finish it (i.e. make sure everything works ok/write tests). I posted the patch in this issue:</div><div><br></div><div><a href="https://bugs.swift.org/browse/SR-210" target="_blank">https://bugs.swift.org/browse/SR-210</a></div><div><br></div><div>My hope is that even though a lot of the work is already done this may serve as good starting point for someone who wants to poke at the SIL Parser (a part of the code base that has not gotten as much attention as others).</div><div><br></div><div>Michael</div>
<img alt="" width="1" height="1" border="0" style="min-height:1px!important;width:1px!important;border-width:0!important;margin-top:0!important;margin-bottom:0!important;margin-right:0!important;margin-left:0!important;padding-top:0!important;padding-bottom:0!important;padding-right:0!important;padding-left:0!important">
</div>
<br>_______________________________________________<br>
swift-dev mailing list<br>
<a href="mailto:swift-dev@swift.org" target="_blank">swift-dev@swift.org</a><br>
<a href="https://lists.swift.org/mailman/listinfo/swift-dev" rel="noreferrer" target="_blank">https://lists.swift.org/mailman/listinfo/swift-dev</a><br>
<br></blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div>