[swift-dev] Request for review on Windows CMake changes

[David Zarzycki]

Can somebody please also speak up to why Windows needs to remove the "-Wl,-z,defs” from CXX_FLAGS? At the very least, I’d like to see the project-wide removal of this useful flag limited to just the Windows builds.

> On Dec 8, 2017, at 20:36, Thomas Roughton via swift-dev <swift-dev at swift.org> wrote:
> 
> Hi all,
> 
> I've had a PR (https://github.com/apple/swift/pull/13140 <https://github.com/apple/swift/pull/13140>) that's been open for about 10 days with a few CMake changes to fix the Windows cross-compile build. I wasn't sure who best to ask to review it, but was suggested to post here with it.
> 
> Could someone familiar with that area maybe add themselves as a reviewer and then later take a look when they get a chance (even if that's not for a few weeks)? There's no particular urgency, but it'd be ideal if possible to have the changes in before it needs to be rebased too many times.
> 
> Thanks,
> Thomas
> _______________________________________________
> swift-dev mailing list
> swift-dev at swift.org
> https://lists.swift.org/mailman/listinfo/swift-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20171209/222976ff/attachment.html>