[swift-dev] PR review process
Slava Pestov
spestov at apple.com
Thu May 4 16:50:57 CDT 2017
I found three PRs from you and looked at two. I’m fine with merging them once the tests pass so I assigned them to myself as a reminder.
I’m assuming this one is not ready yet though: https://github.com/apple/swift/pull/8793 <https://github.com/apple/swift/pull/8793>
Slava
> On May 4, 2017, at 2:40 PM, Slava Pestov via swift-dev <swift-dev at swift.org> wrote:
>
> Hi Pavol,
>
> Bug us mercilessly if you need something reviewed.
>
> Slava
>
>> On May 4, 2017, at 9:26 AM, Pavol Vaskovic via swift-dev <swift-dev at swift.org> wrote:
>>
>> Hello!
>>
>> What is the process for getting a PR reviewed and merged into Swift? My experience so far is inconsistent. Sometimes I get a response in a few hours, discussion starts and I know I'm not wasting effort. At the moment I have 2 PRs open. One for 8 days without response.
>>
>> I understand that Apple folks are pretty busy before WWDC…
>>
>> I was told that I should be patient and wait a week before asking for a review again.
>>
>> Is there a way to improve upon the current state of affairs?
>>
>> Best regards
>> Pavol Vaskovic
>> _______________________________________________
>> swift-dev mailing list
>> swift-dev at swift.org
>> https://lists.swift.org/mailman/listinfo/swift-dev
>
> _______________________________________________
> swift-dev mailing list
> swift-dev at swift.org
> https://lists.swift.org/mailman/listinfo/swift-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20170504/a87b89bc/attachment.html>
More information about the swift-dev
mailing list