[swift-dev] Does it make sense to fold FreeBSD specific patches to Swift into the upstream codebase?

[Brendan Sechter]

Currently the Swift source code is being patched so that it will build on FreeBSD.  Does it make sense to just fold (most of?) these changes into the upstream Swift codebase?


A total of 9 files are patched.  A casual review of the patches indicates that they are all making simple modifications so that FreeBSD is a supported operating system.  Here is an example of one of the patches.


/usr/ports/lang/swift/files/patch-llvm_lib_Support_Unix_Process.inc complete listing


--- llvm/lib/Support/Unix/Process.inc.orig 2016-02-26 00:51:43 UTC

+++ llvm/lib/Support/Unix/Process.inc

@@ -36,7 +36,7 @@

 // DragonFlyBSD, OpenBSD, and Bitrig have deprecated <malloc.h> for

 // <stdlib.h> instead. Unix.h includes this for us already.

 #if defined(HAVE_MALLOC_H) && !defined(__DragonFly__) && \

-    !defined(__OpenBSD__) && !defined(__Bitrig__)

+    !defined(__OpenBSD__) && !defined(__Bitrig__) && !defined(__FreeBSD__)

 #include <malloc.h>

 #endif

 #if defined(HAVE_MALLCTL)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20161002/9d8e4b7d/attachment.html>