[swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #5124

[Jordan Rose]

We’ll need it on the 2.3 branch too.

Jordan

> On Jul 12, 2016, at 13:05, Mishal Shah via swift-dev <swift-dev at swift.org> wrote:
> 
> We are also seeing these failures in swift-3.0-preview-3-branch, can we pull this in to swift-3.0-preview-3-branch?
> 
> https://ci.swift.org/view/swift-3.0-preview-3/job/oss-swift-3.0-preview-3-incremental-RA-osx/34/console <https://ci.swift.org/view/swift-3.0-preview-3/job/oss-swift-3.0-preview-3-incremental-RA-osx/34/console>
> 
> Thanks, 
> Mishal Shah
>> On Jul 12, 2016, at 12:44 PM, Devin Coughlin via swift-dev <swift-dev at swift.org <mailto:swift-dev at swift.org>> wrote:
>> 
>>> 
>>> On Jul 12, 2016, at 11:56 AM, Manman <mren at apple.com <mailto:mren at apple.com>> wrote:
>>> 
>>>> 
>>>> On Jul 12, 2016, at 11:51 AM, Devin Coughlin <dcoughlin at apple.com <mailto:dcoughlin at apple.com>> wrote:
>>>> 
>>>>> 
>>>>> On Jul 12, 2016, at 11:10 AM, Manman via swift-dev <swift-dev at swift.org <mailto:swift-dev at swift.org>> wrote:
>>>>> 
>>>>> 
>>>>>> On Jul 12, 2016, at 10:14 AM, Jordan Rose <jordan_rose at apple.com <mailto:jordan_rose at apple.com>> wrote:
>>>>>> 
>>>>>> It’s possible we’re not treating “macos” the same as “macosx”, and thus changing the way that methods with the same basename get imported. So it probably is that change.
>>>>>> 
>>>>>> …yep, it looks like we look for literal platform name strings in ClangImporter.cpp and ImportDecl.cpp.
>>>>> 
>>>>> So we should just change the string match from “macosx” to “macos” in ClangImporter.cpp.
>>>>> Are you working on fixing this? Or should I look into it? I am still trying to get a successful local build of swift.
>>>> 
>>>> I have a fix for this that I’ve been working on to fix this for master-next — I’ll pull it into master instead.
>>> 
>>> Thanks Devin!
>>> 
>>> @Adrian, thanks for offering to help, Devin will fix the bot failure caused by my change.
>> 
>> Pushed to master in 4b566df9f3eeb8a5255afcd265722dd9e8fc37d0
>> 
>> Devin
>> 
>> _______________________________________________
>> swift-dev mailing list
>> swift-dev at swift.org <mailto:swift-dev at swift.org>
>> https://lists.swift.org/mailman/listinfo/swift-dev <https://lists.swift.org/mailman/listinfo/swift-dev>
> _______________________________________________
> swift-dev mailing list
> swift-dev at swift.org
> https://lists.swift.org/mailman/listinfo/swift-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20160712/69c20396/attachment.html>