[swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #5124
dcoughlin at apple.com
Tue Jul 12 14:44:35 CDT 2016
> On Jul 12, 2016, at 11:56 AM, Manman <mren at apple.com> wrote:
>> On Jul 12, 2016, at 11:51 AM, Devin Coughlin <dcoughlin at apple.com <mailto:dcoughlin at apple.com>> wrote:
>>> On Jul 12, 2016, at 11:10 AM, Manman via swift-dev <swift-dev at swift.org <mailto:swift-dev at swift.org>> wrote:
>>>> On Jul 12, 2016, at 10:14 AM, Jordan Rose <jordan_rose at apple.com <mailto:jordan_rose at apple.com>> wrote:
>>>> It’s possible we’re not treating “macos” the same as “macosx”, and thus changing the way that methods with the same basename get imported. So it probably is that change.
>>>> …yep, it looks like we look for literal platform name strings in ClangImporter.cpp and ImportDecl.cpp.
>>> So we should just change the string match from “macosx” to “macos” in ClangImporter.cpp.
>>> Are you working on fixing this? Or should I look into it? I am still trying to get a successful local build of swift.
>> I have a fix for this that I’ve been working on to fix this for master-next — I’ll pull it into master instead.
> Thanks Devin!
> @Adrian, thanks for offering to help, Devin will fix the bot failure caused by my change.
Pushed to master in 4b566df9f3eeb8a5255afcd265722dd9e8fc37d0
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the swift-dev