[swift-dev] Help needed: Removing inout shadow copy from SILGen

Joe Groff jgroff at apple.com
Thu Jun 9 11:55:35 CDT 2016


> On Jun 8, 2016, at 7:38 PM, Daniel Duan via swift-dev <swift-dev at swift.org> wrote:
> 
> Hi all,
> 
> I'm resuming work on removing the SILGen for the inout shadow copy. Making
> this change involes quite a bit of tests updates.  I'd love some one to review
> this commit in SILGenProlog.cpp before I dive back into the deep end:
> 
> https://github.com/dduan/swift/commit/e56d73c065bec7bdde7c0ffee42b808d1bb52d74
> 
> (It's +5, -12, a small patch).
> 
> Is this on the right track?

The variable binding looks great. We might need to coordinate with the debugger to ensure we still emit debug info the way lldb expects it; cc'ing Adrian and Enrico.

-Joe


More information about the swift-dev mailing list